Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1063413002: Receive all messages in PluginObserver from the RenderFrameHost. (Closed)

Created:
5 years, 8 months ago by Bernhard Bauer
Modified:
5 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Receive all messages in PluginObserver from the RenderFrameHost. BUG=444203 Committed: https://crrev.com/5ebf3147e3a1e66672354fa0412e3cbf964597bc Cr-Commit-Position: refs/heads/master@{#324407}

Patch Set 1 #

Patch Set 2 : review #

Patch Set 3 : update base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/browser/plugins/plugin_observer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 1 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Bernhard Bauer
Please review. (TIL that the browser will happily just swallow unhandled IPC messages :-/ )
5 years, 8 months ago (2015-04-08 09:32:05 UTC) #2
jam
since we're trying to kill RenderView, can you make these use RF routing IDs and ...
5 years, 8 months ago (2015-04-08 15:26:36 UTC) #3
Bernhard Bauer
On 2015/04/08 15:26:36, jam wrote: > since we're trying to kill RenderView, can you make ...
5 years, 8 months ago (2015-04-08 17:49:42 UTC) #4
jam
lgtm
5 years, 8 months ago (2015-04-08 17:55:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063413002/20001
5 years, 8 months ago (2015-04-09 08:41:45 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true in order for the CQ ...
5 years, 8 months ago (2015-04-09 08:41:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063413002/40001
5 years, 8 months ago (2015-04-09 09:32:04 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-09 10:23:21 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 10:24:11 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5ebf3147e3a1e66672354fa0412e3cbf964597bc
Cr-Commit-Position: refs/heads/master@{#324407}

Powered by Google App Engine
This is Rietveld 408576698