Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1063383004: Revert of Remove support for thread-based recompilation (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove support for thread-based recompilation (patchset #1 id:1 of https://codereview.chromium.org/966653002/) Reason for revert: speculative revert due to gc-stress timeouts. Original issue's description: > Remove support for thread-based recompilation > > BUG=v8:3608 > R=yangguo@chromium.org > LOG=y > > Committed: https://crrev.com/ed5db223a19dfe126af012e894582251aa3635d7 > Cr-Commit-Position: refs/heads/master@{#27619} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true BUG=v8:3608 LOG=N Committed: https://crrev.com/c4081d2503b9a7a83ec5243ec95ca3ee90dc38f2 Cr-Commit-Position: refs/heads/master@{#27654}

Patch Set 1 #

Patch Set 2 : manual revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -599 lines) Patch
M BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/cpu-profiler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/execution.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.h View 1 4 chunks +9 lines, -9 lines 0 comments Download
M src/isolate.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M src/objects.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D src/optimizing-compile-dispatcher.h View 1 1 chunk +0 lines, -139 lines 0 comments Download
D src/optimizing-compile-dispatcher.cc View 1 1 chunk +0 lines, -351 lines 0 comments Download
A + src/optimizing-compiler-thread.h View 1 9 chunks +44 lines, -17 lines 0 comments Download
A + src/optimizing-compiler-thread.cc View 1 18 chunks +171 lines, -59 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Yang
Created Revert of Remove support for thread-based recompilation
5 years, 8 months ago (2015-04-08 09:31:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063383004/1
5 years, 8 months ago (2015-04-08 09:32:19 UTC) #2
commit-bot: I haz the power
Failed to apply patch for src/cpu-profiler.h: While running git apply --index -3 -p1; error: patch ...
5 years, 8 months ago (2015-04-08 09:32:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063383004/150001
5 years, 8 months ago (2015-04-08 09:57:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:150001)
5 years, 8 months ago (2015-04-08 10:29:33 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 10:29:42 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4081d2503b9a7a83ec5243ec95ca3ee90dc38f2
Cr-Commit-Position: refs/heads/master@{#27654}

Powered by Google App Engine
This is Rietveld 408576698