Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1063383002: Use the existing user gesture token for PPAPI URL requests (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the existing user gesture token for PPAPI URL requests BUG=474552 R=mkwst@chromium.org Committed: https://crrev.com/c100ceed66afadaf3b35b4dcf438a97d19b977a5 Cr-Commit-Position: refs/heads/master@{#324202}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 3 chunks +5 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-08 07:00:43 UTC) #1
Mike West
LGTM https://codereview.chromium.org/1063383002/diff/1/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): https://codereview.chromium.org/1063383002/diff/1/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode3179 content/renderer/pepper/pepper_plugin_instance_impl.cc:3179: WebString result = container_->executeScriptURL(gurl, false); Nit: Can we ...
5 years, 8 months ago (2015-04-08 07:36:39 UTC) #2
jochen (gone - plz use gerrit)
On 2015/04/08 at 07:36:39, mkwst wrote: > LGTM > > https://codereview.chromium.org/1063383002/diff/1/content/renderer/pepper/pepper_plugin_instance_impl.cc > File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): ...
5 years, 8 months ago (2015-04-08 07:39:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063383002/1
5 years, 8 months ago (2015-04-08 07:40:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 09:39:11 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 09:40:04 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c100ceed66afadaf3b35b4dcf438a97d19b977a5
Cr-Commit-Position: refs/heads/master@{#324202}

Powered by Google App Engine
This is Rietveld 408576698