Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1063373003: Prevent overzealous bailout due to script context. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Prevent overzealous bailout due to script context. This is a follow-up to 2d281e71ac49 and prevents bailouts on empty script contexts in Crankshaft, which don't need allocation. Only non-empty script contexts should cause a bailout. R=bmeurer@chromium.org Committed: https://crrev.com/f3338dd3b01c95dc2b9f332efa54c99eb937c384 Cr-Commit-Position: refs/heads/master@{#27649}

Patch Set 1 #

Patch Set 2 : Adapt tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M src/hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 3 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 8 months ago (2015-04-08 08:09:18 UTC) #1
Benedikt Meurer
lgtm
5 years, 8 months ago (2015-04-08 08:57:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063373003/20001
5 years, 8 months ago (2015-04-08 08:58:54 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-08 09:00:47 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 09:01:03 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3338dd3b01c95dc2b9f332efa54c99eb937c384
Cr-Commit-Position: refs/heads/master@{#27649}

Powered by Google App Engine
This is Rietveld 408576698