Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1063323002: Move base64url.* to CryptAuth component. (Closed)

Created:
5 years, 8 months ago by Tim Song
Modified:
5 years, 8 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@cryptauth_refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move base64url.* to CryptAuth component. The cryptauth component also uses base64url encoding, but cannot depend on proximity_auth. BUG=420316 Committed: https://crrev.com/f32e94c785c695af3772fd7a364dce4abab9df15 Cr-Commit-Position: refs/heads/master@{#324393}

Patch Set 1 #

Total comments: 6

Patch Set 2 : update include paths #

Patch Set 3 : rename path in chrome/browser/chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -138 lines) Patch
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D components/proximity_auth/base64url.h View 1 chunk +0 lines, -29 lines 0 comments Download
D components/proximity_auth/base64url.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D components/proximity_auth/base64url_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M components/proximity_auth/client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/cryptauth/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
A + components/proximity_auth/cryptauth/base64url.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + components/proximity_auth/cryptauth/base64url.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/proximity_auth/cryptauth/base64url_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_enrollment_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/wire_message.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Tim Song
5 years, 8 months ago (2015-04-08 02:32:53 UTC) #2
Ilya Sherman
LGTM % nits: https://codereview.chromium.org/1063323002/diff/1/components/proximity_auth/cryptauth/base64url.cc File components/proximity_auth/cryptauth/base64url.cc (right): https://codereview.chromium.org/1063323002/diff/1/components/proximity_auth/cryptauth/base64url.cc#newcode5 components/proximity_auth/cryptauth/base64url.cc:5: #include "components/proximity_auth/base64url.h" Please update the include ...
5 years, 8 months ago (2015-04-08 18:24:32 UTC) #3
Tim Song
https://codereview.chromium.org/1063323002/diff/1/components/proximity_auth/cryptauth/base64url.cc File components/proximity_auth/cryptauth/base64url.cc (right): https://codereview.chromium.org/1063323002/diff/1/components/proximity_auth/cryptauth/base64url.cc#newcode5 components/proximity_auth/cryptauth/base64url.cc:5: #include "components/proximity_auth/base64url.h" On 2015/04/08 18:24:32, Ilya Sherman wrote: > ...
5 years, 8 months ago (2015-04-08 21:31:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063323002/40001
5 years, 8 months ago (2015-04-09 07:03:28 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-09 07:49:20 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 07:50:12 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f32e94c785c695af3772fd7a364dce4abab9df15
Cr-Commit-Position: refs/heads/master@{#324393}

Powered by Google App Engine
This is Rietveld 408576698