Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1063273002: Revert of Add the ability to build Chrome tools to the Win Clang build script. (Closed)

Created:
5 years, 8 months ago by Nico
Modified:
5 years, 8 months ago
Reviewers:
hans, dcheng
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add the ability to build Chrome tools to the Win Clang build script. (patchset #2 id:20001 of https://codereview.chromium.org/1068603002/) Reason for revert: Broke all bots on http://build.chromium.org/p/chromium.fyi/console?category=win%20clang , they fail with: ________ running 'C:\b\depot_tools\python276_bin\python.exe src/tools/clang/scripts/update.py --if-needed' in 'C:\b\build\slave\CrWinClang\build' usage: update.py [-h] [--no-clobber] [--tools [TOOLS [TOOLS ...]]] update.py: error: unrecognized arguments: --if-needed Probably easy to fix (just add a dummy --if-needed parameter to argparse), but reverting to get that waterfall back to green. Original issue's description: > Add the ability to build Chrome tools to the Win Clang build script. > > BUG=424436, 467287 > > Committed: https://crrev.com/475949d9430b6a759ce759f2133dd3a1577d0d0b > Cr-Commit-Position: refs/heads/master@{#324089} TBR=hans@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=424436, 467287 Committed: https://crrev.com/d6aece7c6748553aa11b9dbacd27b5ec4d2d363c Cr-Commit-Position: refs/heads/master@{#324138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -46 lines) Patch
M tools/clang/scripts/update.py View 6 chunks +7 lines, -46 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Add the ability to build Chrome tools to the Win Clang build ...
5 years, 8 months ago (2015-04-07 22:36:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063273002/1
5 years, 8 months ago (2015-04-07 22:38:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 22:40:13 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 22:41:02 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6aece7c6748553aa11b9dbacd27b5ec4d2d363c
Cr-Commit-Position: refs/heads/master@{#324138}

Powered by Google App Engine
This is Rietveld 408576698