.gitignore - Issue 1063233004: Teach dart_package to understand the packages/ subdirectory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: .gitignore

Issue 1063233004: Teach dart_package to understand the packages/ subdirectory (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Response to review Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 *.pyc	1 *.pyc

2 *~	2 *~

3 .*.sw?	3 .*.sw?

4 .DS_Store	4 .DS_Store

5 .classpath	5 .classpath

6 .cproject	6 .cproject

7 .gdb_history	7 .gdb_history

8 .gdbinit	8 .gdbinit

9 .landmines	9 .landmines

10 .project	10 .project

	11 .pub-cache/
	jamesr 2015/04/09 20:04:04 can we put this in a more obviously named director can we put this in a more obviously named directory (preferably not a hidden one)? blundell 2015/04/10 10:06:49 Done. Show quoted text On 2015/04/09 20:04:04, jamesr wrote: > can we put this in a more obviously named directory (preferably not a hidden > one)? Done.
11 .pydevproject	12 .pydevproject

12 .checkstyle	13 .checkstyle

13 cscope.*	14 cscope.*

	15 pubspec.lock
	jamesr 2015/04/09 20:04:04 hmm, why would this lockfile be ignored? hmm, why would this lockfile be ignored? blundell 2015/04/10 10:06:49 Done. Show quoted text On 2015/04/09 20:04:04, jamesr wrote: > hmm, why would this lockfile be ignored? Done.
14 Session.vim	16 Session.vim

15 tags	17 tags

16 Thumbs.db	18 Thumbs.db

17 v8.log	19 v8.log

	20 packages/
	jamesr 2015/04/09 20:04:04 could this be named more obviously as well? dart_p could this be named more obviously as well? dart_packages/ or the like? blundell 2015/04/10 10:06:49 The "packages/" name is a Dart convention that the Show quoted text On 2015/04/09 20:04:04, jamesr wrote: > could this be named more obviously as well? dart_packages/ or the like? The "packages/" name is a Dart convention that there's no way to change AFAIK. zra 2015/04/10 15:04:09 Correct. pub is hardcoded to use a packages/ direc Show quoted text On 2015/04/10 10:06:49, blundell wrote: > On 2015/04/09 20:04:04, jamesr wrote: > > could this be named more obviously as well? dart_packages/ or the like? > > The "packages/" name is a Dart convention that there's no way to change AFAIK. Correct. pub is hardcoded to use a packages/ directory.
18 /build/util/LASTCHANGE*	21 /build/util/LASTCHANGE*

19 /build/linux/bin/eu-strip	22 /build/linux/bin/eu-strip

20 /build/win_toolchain.json	23 /build/win_toolchain.json

21 /buildtools/	24 /buildtools/

22 # The Chrome OS build creates a /c symlink due to http://crbug.com/54866.	25 # The Chrome OS build creates a /c symlink due to http://crbug.com/54866.

23 # TODO(vtl): Check if this is still true.	26 # TODO(vtl): Check if this is still true.

24 /c	27 /c

25 /dart/	28 /dart/

26 /native_client/	29 /native_client/

27 /out/	30 /out/

(...skipping 27 matching lines...) Expand all Loading...
55 /third_party/pywebsocket/src/	58 /third_party/pywebsocket/src/

56 /third_party/requests/src/	59 /third_party/requests/src/

57 /third_party/sfntly/cpp/	60 /third_party/sfntly/cpp/

58 /third_party/skia/	61 /third_party/skia/

59 /third_party/smhasher/src/	62 /third_party/smhasher/src/

60 /third_party/yasm/binaries/	63 /third_party/yasm/binaries/

61 /third_party/yasm/source/patched-yasm/	64 /third_party/yasm/source/patched-yasm/

62 /tools/grit/	65 /tools/grit/

63 /tools/gyp/	66 /tools/gyp/

64 /v8/	67 /v8/

OLD	NEW

« no previous file with comments | « no previous file | BUILD.gn » ('j') | mojo/public/dart/rules.gni » ('J')