mojo/dart/apptest/pubspec.yaml - Issue 1063233004: Teach dart_package to understand the packages/ subdirectory

Side by Side Diff: mojo/dart/apptest/pubspec.yaml

Issue 1063233004: Teach dart_package to understand the packages/ subdirectory (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Remove dart-packages Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 name: mojo_apptest
	tonyg 2015/04/08 13:52:37 Not necessary in this patch, but now that this is Not necessary in this patch, but now that this is a real pub, I think it'd be appropriate to give it a description and everything and actually publish it like we publish the mojo and sky pubs. Then we can remove that hack that uploads a specific version to cloud storage and other repos can just depend on the pub itself. blundell 2015/04/09 11:53:41 It's a half-man half-monster now, because it also Show quoted text On 2015/04/08 13:52:37, tonyg wrote: > Not necessary in this patch, but now that this is a real pub, I think it'd be > appropriate to give it a description and everything and actually publish it like > we publish the mojo and sky pubs. Then we can remove that hack that uploads a > specific version to cloud storage and other repos can just depend on the pub > itself. It's a half-man half-monster now, because it also has dependencies specified in the BUILD.gn file (which will generally be the case for dart_packages going forward). Hmmm... tonyg 2015/04/09 12:55:56 Seems like a good area for further thought in a fo Show quoted text On 2015/04/09 11:53:41, blundell wrote: > On 2015/04/08 13:52:37, tonyg wrote: > > Not necessary in this patch, but now that this is a real pub, I think it'd be > > appropriate to give it a description and everything and actually publish it > like > > we publish the mojo and sky pubs. Then we can remove that hack that uploads a > > specific version to cloud storage and other repos can just depend on the pub > > itself. > > It's a half-man half-monster now, because it also has dependencies specified in > the BUILD.gn file (which will generally be the case for dart_packages going > forward). Hmmm... Seems like a good area for further thought in a follow-up. I can definitely imagine that users of the mojo sdk will want a way to use the build system and still produce a dart pub. One hand-wavy idea might be to add a new gn rule, "dart_pub_app". It'd depend on dart_packages and/or dart_packed_apps and their partially specified pubspec.yaml. And it'd produce a new directory in the out dir that contains the full pub to upload (including a pubspec.yaml with additional dependencies if needed). We'd know we have something workable if it can get rid of sky/tools/deploy_sdk.py. Then we'd have a primitive "dart_packaged_app+uses_pub" for pub->gn and we could add another primitive "dart_pub_app" for gn->pub. blundell 2015/04/09 15:34:36 I don't think it's quite that simple, because the Show quoted text On 2015/04/09 12:55:56, tonyg wrote: > On 2015/04/09 11:53:41, blundell wrote: > > On 2015/04/08 13:52:37, tonyg wrote: > > > Not necessary in this patch, but now that this is a real pub, I think it'd > be > > > appropriate to give it a description and everything and actually publish it > > like > > > we publish the mojo and sky pubs. Then we can remove that hack that uploads > a > > > specific version to cloud storage and other repos can just depend on the pub > > > itself. > > > > It's a half-man half-monster now, because it also has dependencies specified > in > > the BUILD.gn file (which will generally be the case for dart_packages going > > forward). Hmmm... > > Seems like a good area for further thought in a follow-up. I can definitely > imagine that users of the mojo sdk will want a way to use the build system and > still produce a dart pub. > > One hand-wavy idea might be to add a new gn rule, "dart_pub_app". It'd depend on > dart_packages and/or dart_packed_apps and their partially specified > pubspec.yaml. And it'd produce a new directory in the out dir that contains the > full pub to upload (including a pubspec.yaml with additional dependencies if > needed). We'd know we have something workable if it can get rid of > sky/tools/deploy_sdk.py. > > Then we'd have a primitive "dart_packaged_app+uses_pub" for pub->gn and we could > add another primitive "dart_pub_app" for gn->pub. I don't think it's quite that simple, because the main reason to use BUILD.gn will be to allow dependencies on mojoms, and I don't think that in general we should be publishing mojom.dart files.
	2 version: 0.0.1

	3 dependencies:

	4 unittest: any
	tonyg 2015/04/08 13:52:37 I think think this'd be more future-proof if we we I think think this'd be more future-proof if we went with the recommended pattern, ">=0.11.5+4 <0.12.0", as per: https://pub.dartlang.org/packages/unittest Although, maybe that complicates the README.md because if someone wants to switch to v0.12, they edit this file and the lock? blundell 2015/04/09 11:53:41 Done. Show quoted text On 2015/04/08 13:52:37, tonyg wrote: > I think think this'd be more future-proof if we went with the recommended > pattern, ">=0.11.5+4 <0.12.0", as per: > https://pub.dartlang.org/packages/unittest > > Although, maybe that complicates the README.md because if someone wants to > switch to v0.12, they edit this file and the lock? Done.
OLD	NEW

« mojo/dart/apptest/pubspec.lock ('K') | « mojo/dart/apptest/pubspec.lock ('k') | mojo/public/dart/rules.gni » ('j') | mojo/public/dart/rules.gni » ('J')