build/module_args/mojo.gni - Issue 1063233004: Teach dart_package to understand the packages/ subdirectory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/module_args/mojo.gni

Issue 1063233004: Teach dart_package to understand the packages/ subdirectory (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Remove dart-packages Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # This variable should point to the parent directory of the Mojo SDK.	5 # This variable should point to the parent directory of the Mojo SDK.

6 mojo_sdk_root = "//"	6 mojo_sdk_root = "//"

7	7

	8 # This variable should point to the parent directory of the Dart SDK. It can be
	tonyg 2015/04/08 13:52:37 It's not really clear to me why this should point It's not really clear to me why this should point to the parent instead of "//third_party/dart-sdk/dart-sdk/" blundell 2015/04/09 11:53:41 Just for consistency with mojo_sdk_root :). Show quoted text On 2015/04/08 13:52:37, tonyg wrote: > It's not really clear to me why this should point to the parent instead of > "//third_party/dart-sdk/dart-sdk/" Just for consistency with mojo_sdk_root :).
	9 # omitted if Dart is not being used.

	10 mojo_dart_sdk_root = "//third_party/dart-sdk/"

	11

8 # To build the Mojo shell from source, set this variable to true. To use the	12 # To build the Mojo shell from source, set this variable to true. To use the

9 # prebuilt shell, omit this variable or set it to false. Note that the prebuilt	13 # prebuilt shell, omit this variable or set it to false. Note that the prebuilt

10 # shell will be used only on platforms for which it is published (currently	14 # shell will be used only on platforms for which it is published (currently

11 # Linux and Android).	15 # Linux and Android).

12 mojo_build_mojo_shell_from_source = true	16 mojo_build_mojo_shell_from_source = true

13	17

14 # To build the network service from source, set this variable to true. To use	18 # To build the network service from source, set this variable to true. To use

15 # the prebuilt network service, omit this variable or set it to false.	19 # the prebuilt network service, omit this variable or set it to false.

16 mojo_build_network_service_from_source = false	20 mojo_build_network_service_from_source = false

OLD	NEW

« no previous file with comments | « BUILD.gn ('k') | mojo/dart/apptest/BUILD.gn » ('j') | mojo/dart/apptest/pubspec.lock » ('J')