Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: components/metrics/proto/system_profile.proto

Issue 1063153002: Fix comment on logs entry. Extension render crashed not part of normal renderer crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/proto/system_profile.proto
diff --git a/components/metrics/proto/system_profile.proto b/components/metrics/proto/system_profile.proto
index e76989ceda94dbee4e4a3e5326d6be30789ead2a..4676b7aa1dfb85f2545dc08932821c2258972cfe 100644
--- a/components/metrics/proto/system_profile.proto
+++ b/components/metrics/proto/system_profile.proto
@@ -446,9 +446,8 @@ message SystemProfileProto {
optional int32 renderer_crash_count = 3;
optional int32 renderer_hang_count = 4;
- // Number of renderer crashes that were for extensions.
- // TODO(isherman): Figure out whether this is also counted in
- // |renderer_crash_count|.
+ // Number of renderer crashes that were for extensions. These crashes are
+ // not counted in renderer_crash_count.
optional int32 extension_renderer_crash_count = 5;
// Number of non-renderer child process crashes.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698