Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1063143003: upload.py: Fix immutable exception attribute. (Closed)

Created:
5 years, 8 months ago by dnj
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

upload.py: Fix immutable exception attribute. BUG=chromium:356813 TEST=local - Actually failed login, watched error message get printed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M third_party/upload.py View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dnj
So much for minimal changes. Apparently this attribute is immutable. PTAL.
5 years, 8 months ago (2015-04-07 19:20:16 UTC) #2
ghost stip (do not use)
lgtm
5 years, 8 months ago (2015-04-07 19:23:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063143003/1
5 years, 8 months ago (2015-04-07 19:27:14 UTC) #5
commit-bot: I haz the power
Presubmit check for 1063143003-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-07 19:28:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063143003/1
5 years, 8 months ago (2015-04-07 19:31:00 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 19:33:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294705

Powered by Google App Engine
This is Rietveld 408576698