Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 106313003: Reland "Allocation site support for monomorphic StringAdds in BinaryOps". (Closed)

Created:
6 years, 11 months ago by Benedikt Meurer
Modified:
6 years, 11 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Reland "Allocation site support for monomorphic StringAdds in BinaryOps". R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+840 lines, -305 lines) Patch
M src/arm/code-stubs-arm.cc View 4 chunks +56 lines, -12 lines 0 comments Download
M src/ast.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/code-stubs.h View 6 chunks +93 lines, -8 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 6 chunks +34 lines, -6 lines 0 comments Download
M src/hydrogen.h View 5 chunks +54 lines, -8 lines 0 comments Download
M src/hydrogen.cc View 14 chunks +321 lines, -224 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +30 lines, -20 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +20 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +42 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.h View 3 chunks +21 lines, -2 lines 0 comments Download
M src/ic.cc View 6 chunks +59 lines, -6 lines 0 comments Download
M src/objects.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/type-info.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/type-info.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M src/typing.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +53 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Ulan, This is basically the original CL (https://codereview.chromium.org/106453003/) plus the build fix from https://codereview.chromium.org/122523003/ ...
6 years, 11 months ago (2014-01-02 11:49:49 UTC) #1
ulan
lgtm
6 years, 11 months ago (2014-01-02 12:03:01 UTC) #2
Benedikt Meurer
6 years, 11 months ago (2014-01-02 15:31:41 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r18444 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698