Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1879)

Unified Diff: Source/platform/heap/Heap.cpp

Issue 1063083002: Oilpan: Consider PartitionAlloc's memory usage when triggering a GC (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/heap/Heap.cpp
diff --git a/Source/platform/heap/Heap.cpp b/Source/platform/heap/Heap.cpp
index 16c67093890111d27448cde922ab3d20f9a7e54f..3fc92f30dd123e5b77418b34d0abe8de16ec1421 100644
--- a/Source/platform/heap/Heap.cpp
+++ b/Source/platform/heap/Heap.cpp
@@ -2663,24 +2663,7 @@ void Heap::resetHeapCounters()
s_allocatedObjectSize = 0;
s_markedObjectSize = 0;
-
- // Similarly, reset the amount of externally allocated memory.
- s_externallyAllocatedBytes = 0;
- s_externallyAllocatedBytesAlive = 0;
-
- s_requestedUrgentGC = false;
-}
-
-void Heap::requestUrgentGC()
-{
- // The urgent-gc flag will be considered the next time an out-of-line
- // allocation is made. Bump allocations from the current block will
- // go ahead until it can no longer service an allocation request.
- //
- // FIXME: if that delays urgently needed GCs for too long, consider
- // flushing out per-heap "allocation points" to trigger the GC
- // right away.
- releaseStore(&s_requestedUrgentGC, 1);
+ s_externalObjectSizeAtLastGC = WTF::Partitions::totalSizeOfCommittedPages();
}
Visitor* Heap::s_markingVisitor;
@@ -2700,10 +2683,7 @@ size_t Heap::s_markedObjectSize = 0;
// We don't want to use 0 KB for the initial value because it may end up
// triggering the first GC of some thread too prematurely.
size_t Heap::s_estimatedLiveObjectSize = 512 * 1024;
-
-size_t Heap::s_externallyAllocatedBytes = 0;
-size_t Heap::s_externallyAllocatedBytesAlive = 0;
-unsigned Heap::s_requestedUrgentGC = false;
+size_t Heap::s_externalObjectSizeAtLastGC = 0;
double Heap::s_estimatedMarkingTimePerByte = 0.0;
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698