Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1063073005: remove one more analyzer related TODO (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/js_codegen.dart
diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart
index c0b39ff768bc3edc79ce4fc16151935b2c9ae907..dd157c8c59d808a3c68f297e1af7c0bffe7771cb 100644
--- a/lib/src/codegen/js_codegen.dart
+++ b/lib/src/codegen/js_codegen.dart
@@ -2495,8 +2495,6 @@ bool _isPotentiallyMutated(VariableElement e, [AstNode context]) {
/// Adapted from VariableResolverVisitor. Finds an assignment to a given
/// local variable.
-// TODO(jmesserly): change type annotation to not be *Impl once
-// isPotentiallyMutated is available on VariableElement.
class _AssignmentFinder extends RecursiveAstVisitor {
final VariableElement _variable;
bool _potentiallyMutated = false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698