Retrieval of information by release channel

tools/release/releases.py

 #!/usr/bin/env python
 # Copyright 2014 the V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This script retrieves the history of all V8 branches and
 # their corresponding Chromium revisions.
 
 # Requires a chromium checkout with branch heads:
 # gclient sync --with_branch_heads
@@ skipping 426 matching lines @@
   MESSAGE = "Clean up."
 
   def RunStep(self):
     self.CommonCleanup()
 
 
 class WriteOutput(Step):
   MESSAGE = "Print output."
 
   def Run(self):
+
+    output = {'releases':self['releases'],
+              'chrome_releases':self['chrome_releases']}
+
     if self._options.csv:
       with open(self._options.csv, "w") as f:
         writer = csv.DictWriter(f,
                                 ["version", "branch", "revision",
                                  "chromium_revision", "patches_merged"],
                                 restval="",
                                 extrasaction="ignore")
         for release in self["releases"]:
           writer.writerow(release)
     if self._options.json:
       with open(self._options.json, "w") as f:
-        f.write(json.dumps(self["releases"]))
+        f.write(json.dumps(output))
     if not self._options.csv and not self._options.json:
-      print self["releases"]  # pragma: no cover
+      print output  # pragma: no cover
 
 
 class Releases(ScriptsBase):
   def _PrepareOptions(self, parser):
     parser.add_argument("-b", "--branch", default="recent",
                         help=("The branch to analyze. If 'all' is specified, "
                               "analyze all branches. If 'recent' (default) "
                               "is specified, track beta, stable and "
                               "candidates."))
     parser.add_argument("-c", "--chromium",
                         help=("The path to your Chromium src/ "
                               "directory to automate the V8 roll."))
     parser.add_argument("--csv", help="Path to a CSV file for export.")
     parser.add_argument("-m", "--max-releases", type=int, default=0,
                         help="The maximum number of releases to track.")
     parser.add_argument("--json", help="Path to a JSON file for export.")
 
   def _ProcessOptions(self, options):  # pragma: no cover
     options.force_readline_defaults = True
     return True
 
   def _Config(self):
     return {
       "BRANCHNAME": "retrieve-v8-releases",
       "PERSISTFILE_BASENAME": "/tmp/v8-releases-tempfile",
     }
 
   def _Steps(self):
+
     return [
       Preparation,
       RetrieveV8Releases,
       UpdateChromiumCheckout,
       RetrieveChromiumV8Releases,
       RietrieveChromiumBranches,

[Michael Achenbach, 2015/04/15 09:27:53]

nit: could you clean up my old spelling mistake: Retrieve...

[Michael Hablich, 2015/04/15 09:35:44]

Acknowledged.

+      RetrieveInformationOnCanary,
       CleanUp,
-      WriteOutput,
+      WriteOutput

[Michael Achenbach, 2015/04/15 09:27:53]

nit: , in the end are generally recommended in case the ending brackets are in a
new line - makes the diffs easier to read when new lines are added

[Michael Hablich, 2015/04/15 09:35:44]

Acknowledged.

     ]
 
 

[Michael Achenbach, 2015/04/15 09:27:53]

Please move class up so that the order of steps matches the order of classes (at
least that was the convention so far).

[Michael Hablich, 2015/04/15 09:35:44]

Acknowledged.

+class RetrieveInformationOnCanary(Step):
+  MESSAGE = 'Retrieves relevant information on the latest Chrome Canary'
+
+  def Run(self):
+
+    params = None
+    resultRaw = self.ReadURL('http://omahaproxy.appspot.com/all.json', params, wait_plan=[5, 20])

[Michael Achenbach, 2015/04/15 09:27:53]

nit: 80 chars

[Michael Achenbach, 2015/04/15 09:27:53]

nit: All v8-side scripts use " instead of ' due to stupid historical reasons.
Please stick to one or change them all :)

[Michael Achenbach, 2015/04/15 09:27:53]

nit (style): Use _ for local variables not camel case:
result_raw
recent_releases
current_os
current_canary
current_version
etc

[Michael Hablich, 2015/04/15 09:35:44]

Acknowledged.

[Michael Hablich, 2015/04/15 09:35:44]

Acknowledged.

[Michael Hablich, 2015/04/15 09:35:44]

Acknowledged.

[Michael Hablich, 2015/04/15 09:35:45]

Acknowledged.

+    recentReleases = json.loads(resultRaw)
+    print recentReleases

[Michael Achenbach, 2015/04/15 09:27:53]

Can the print go away in the final version? Or pretty print:
print json.dumps(recentReleases, indent=2, sort_keys=True)

[Michael Hablich, 2015/04/15 09:35:45]

Will go away.

+
+    allCanaries = []

[Michael Achenbach, 2015/04/15 09:27:53]

Call just canaries?

[Michael Hablich, 2015/04/15 09:35:44]

Acknowledged.

+
+    for currentOS in recentReleases:
+      for currentVersion in currentOS['versions']:
+        currentCandidate = {'version':currentVersion['version'],

[Michael Achenbach, 2015/04/15 09:27:53]

Move under the condition below? Or are there coming more channels?

[Michael Achenbach, 2015/04/15 09:27:53]

Please qualify 'version' since we have more now, e.g. chrome_version. Above in
this script, version referred to the v8 version (should have been qualified
there as well).

[Michael Hablich, 2015/04/15 09:35:44]

Acknowledged.

[Michael Hablich, 2015/04/15 09:35:44]

More channels coming. Wanted to finish Canary first (show on gui). At least Dev
will follow shortly.

+                           'os':currentVersion['os'],

[Michael Achenbach, 2015/04/15 09:27:53]

nit: indentation - either align all keys or use a new line (better):
currentCandidate = {
  'version':currentVersion['version'],
  'os':currentVersion['os'],
  ...
}

[Michael Hablich, 2015/04/15 09:35:44]

Acknowledged.

+                           'release_date': currentVersion['current_reldate'],
+                           'v8_version':currentVersion['v8_version']}

[Michael Achenbach, 2015/04/15 09:27:53]

nit: always one space after : also below

[Michael Hablich, 2015/04/15 09:35:44]

Acknowledged.

+
+        if currentVersion['channel'] == 'canary':
+          allCanaries.append(currentCandidate)
+
+    chromeReleases = {'canaries':allCanaries}
+    self['chrome_releases'] = chromeReleases
+
+
 if __name__ == "__main__":  # pragma: no cover
   sys.exit(Releases().Run())