Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 1063063002: Add Clank to the gn exec_script whitelist (Closed)

Created:
5 years, 8 months ago by dgn
Modified:
5 years, 8 months ago
Reviewers:
Bernhard Bauer, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Clank to the gn exec_script whitelist Fixes downstream gn bots affected by https://codereview.chromium.org/1063873002 TBR=brettw@chromium.org BUG=474506 Committed: https://crrev.com/470951714e0ea3656dab463bf14dad99e83db977 Cr-Commit-Position: refs/heads/master@{#324028}

Patch Set 1 #

Total comments: 1

Patch Set 2 : replaced issue number with a link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M .gn View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063063002/1
5 years, 8 months ago (2015-04-07 09:52:36 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-07 09:52:37 UTC) #4
Bernhard Bauer
LGTM w/ a nit: https://codereview.chromium.org/1063063002/diff/1/.gn File .gn (right): https://codereview.chromium.org/1063063002/diff/1/.gn#newcode113 .gn:113: # TODO(dgn): Layer violation but ...
5 years, 8 months ago (2015-04-07 10:05:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063063002/20001
5 years, 8 months ago (2015-04-07 10:09:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 10:37:56 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/470951714e0ea3656dab463bf14dad99e83db977 Cr-Commit-Position: refs/heads/master@{#324028}
5 years, 8 months ago (2015-04-07 10:38:51 UTC) #11
brettw
5 years, 8 months ago (2015-04-07 17:34:00 UTC) #12
Message was sent while issue was closed.
LGTM. This approach is fine with me for now. If this is causing a lot of
problems we can revisit.

I hope, though, that the result is clank tries not to add exec_script calls so
it doesn't come up! :)

Powered by Google App Engine
This is Rietveld 408576698