Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1063033002: Move ChromeShellPKCS11AuthenticationManager to Empty... (Closed)

Created:
5 years, 8 months ago by Changwan Ryu
Modified:
5 years, 8 months ago
Reviewers:
Yaron, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ChromeShellPKCS11AuthenticationManager to Empty... Change the name and move it to a more generic place so that it can be used by ChromeMobileApplication. BUG=428860 Committed: https://crrev.com/9bf2589b5e25e120b7b15fac2d28208f5e037e41 Cr-Commit-Position: refs/heads/master@{#324381}

Patch Set 1 #

Patch Set 2 : moved to subpackage and made it backward compatible #

Patch Set 3 : #

Patch Set 4 : fixed findbug error #

Messages

Total messages: 20 (8 generated)
Changwan Ryu
5 years, 8 months ago (2015-04-07 07:53:43 UTC) #2
Yaron
lgtm
5 years, 8 months ago (2015-04-07 13:45:14 UTC) #3
newt (away)
Is there a subpackage we could put this file in? It seems much too specialized ...
5 years, 8 months ago (2015-04-07 17:47:45 UTC) #4
Changwan Ryu
On 2015/04/07 17:47:45, newt wrote: > Is there a subpackage we could put this file ...
5 years, 8 months ago (2015-04-08 02:53:14 UTC) #5
Yaron
On 2015/04/08 02:53:14, Changwan Ryu wrote: > On 2015/04/07 17:47:45, newt wrote: > > Is ...
5 years, 8 months ago (2015-04-08 13:12:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063033002/40001
5 years, 8 months ago (2015-04-09 00:47:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/65047)
5 years, 8 months ago (2015-04-09 02:07:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063033002/40001
5 years, 8 months ago (2015-04-09 03:06:25 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/65090)
5 years, 8 months ago (2015-04-09 03:58:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063033002/60001
5 years, 8 months ago (2015-04-09 04:50:38 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-09 05:18:55 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 05:19:39 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9bf2589b5e25e120b7b15fac2d28208f5e037e41
Cr-Commit-Position: refs/heads/master@{#324381}

Powered by Google App Engine
This is Rietveld 408576698