Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: ash/wm/drag_window_resizer_unittest.cc

Issue 106303005: Fix AdjustBoundsToEnsureWindowVisibility to work with non primary display bounds (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/drag_window_resizer_unittest.cc
diff --git a/ash/wm/drag_window_resizer_unittest.cc b/ash/wm/drag_window_resizer_unittest.cc
index 0514ad5a0490a49df5fd9fb8e8feb9ba26a287a1..5dcd0564b29874df8b488eedb2e8595a109fdb62 100644
--- a/ash/wm/drag_window_resizer_unittest.cc
+++ b/ash/wm/drag_window_resizer_unittest.cc
@@ -244,12 +244,9 @@ TEST_F(DragWindowResizerTest, WindowDragWithMultiDisplays) {
gfx::Rect intersect(window_->GetRootWindow()->GetBoundsInScreen());
intersect.Intersect(window_bounds_in_screen);
- // TODO(oshima): Following condition fails without docked window resizer.
- // Proper fix caused the other failures, so I'm disabling these
- // for m33 (Which is harmless).
- // EXPECT_LE(10, intersect.width());
- // EXPECT_LE(10, intersect.height());
- // EXPECT_TRUE(window_bounds_in_screen.Contains(gfx::Point(800, 10)));
+ EXPECT_LE(10, intersect.width());
+ EXPECT_LE(10, intersect.height());
+ EXPECT_TRUE(window_bounds_in_screen.Contains(gfx::Point(800, 10)));
}
// Dropping a window that is larger than the destination work area
@@ -516,6 +513,11 @@ TEST_F(DragWindowResizerTest, CursorDeviceScaleFactor) {
// Move window from the root window with 2.0 device scale factor to the root
// window with 1.0 device scale factor.
{
+ // Make sure the window is on the default container first.
+ aura::Window* default_container =
+ GetRootWindowController(root_windows[1])->GetContainer(
+ internal::kShellWindowId_DefaultContainer);
+ default_container->AddChild(window_.get());
window_->SetBoundsInScreen(
gfx::Rect(600, 0, 50, 60),
Shell::GetScreen()->GetDisplayNearestWindow(root_windows[1]));

Powered by Google App Engine
This is Rietveld 408576698