Make WebUI webview content script work with incognito.

Make WebUI webview content script work with incognito.

In WebUIUserScriptLoader, if it is incognito mode, we need to get the
OffTheRecordContext and pass it to URLfetchers to load user scripts.
Currently, UserScriptLoader can only refer to regular profiles.
To fix this, we pass in a flag to show whether it is incognito mode
when adding scripts. We are able to choose the correct profile pointer
by using this flag.

BUG=461052
Committed: https://crrev.com/6233f60f246f03cd193bd9ecebbeb314813406d8
Cr-Commit-Position: refs/heads/master@{#327096}

[Xi Han, 2015-04-23 17:49:43]

hanxi@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Xi Han, 2015-04-23 17:49:44]

Hi Devlin, can you review this patch parallel? Thanks a lot:)

[Devlin, 2015-04-23 17:53:47]

https://codereview.chromium.org/1062963006/diff/1/extensions/browser/web_ui_u...
File extensions/browser/web_ui_user_script_loader.cc (right):

https://codereview.chromium.org/1062963006/diff/1/extensions/browser/web_ui_u...
extensions/browser/web_ui_user_script_loader.cc:110: content::BrowserContext*
browser_context = iter->second.is_incognito
Can't we basically replace this whole patch with
content::BrowserContext* browser_context =
    content::RenderProcessHost::FromID(render_process_id)->GetBrowserContext();
?

[Xi Han, 2015-04-23 18:02:46]

On 2015/04/23 17:53:47, Devlin wrote:
>
https://codereview.chromium.org/1062963006/diff/1/extensions/browser/web_ui_u...
> File extensions/browser/web_ui_user_script_loader.cc (right):
> 
>
https://codereview.chromium.org/1062963006/diff/1/extensions/browser/web_ui_u...
> extensions/browser/web_ui_user_script_loader.cc:110: content::BrowserContext*
> browser_context = iter->second.is_incognito
> Can't we basically replace this whole patch with
> content::BrowserContext* browser_context =
>    
content::RenderProcessHost::FromID(render_process_id)->GetBrowserContext();
> ?

Can you get even a off_the_record_context from RenderProcessHost?

[Xi Han, 2015-04-23 18:02:47]

On 2015/04/23 17:53:47, Devlin wrote:
>
https://codereview.chromium.org/1062963006/diff/1/extensions/browser/web_ui_u...
> File extensions/browser/web_ui_user_script_loader.cc (right):
> 
>
https://codereview.chromium.org/1062963006/diff/1/extensions/browser/web_ui_u...
> extensions/browser/web_ui_user_script_loader.cc:110: content::BrowserContext*
> browser_context = iter->second.is_incognito
> Can't we basically replace this whole patch with
> content::BrowserContext* browser_context =
>    
content::RenderProcessHost::FromID(render_process_id)->GetBrowserContext();
> ?

Can you get even a off_the_record_context from RenderProcessHost?

[Devlin, 2015-04-23 18:04:42]

On 2015/04/23 18:02:47, Xi Han wrote:
> On 2015/04/23 17:53:47, Devlin wrote:
> >
>
https://codereview.chromium.org/1062963006/diff/1/extensions/browser/web_ui_u...
> > File extensions/browser/web_ui_user_script_loader.cc (right):
> > 
> >
>
https://codereview.chromium.org/1062963006/diff/1/extensions/browser/web_ui_u...
> > extensions/browser/web_ui_user_script_loader.cc:110:
content::BrowserContext*
> > browser_context = iter->second.is_incognito
> > Can't we basically replace this whole patch with
> > content::BrowserContext* browser_context =
> >    
> content::RenderProcessHost::FromID(render_process_id)->GetBrowserContext();
> > ?
> 
> Can you get even a off_the_record_context from RenderProcessHost?

A render process has only one context, which may be off the record or on the
record.  If the process is for an off the record context, then yes, it will
return that off the record context.

[Xi Han, 2015-04-23 19:13:56]

Cool, that sounds a really easy fix. PTAL, thanks!

[Devlin, 2015-04-27 15:58:14]

Would it be possible to add a test for this, to make sure it works with
incognito WebUI?

[Xi Han, 2015-04-27 17:39:14]

Patchset #3 (id:40001) has been deleted

[Xi Han, 2015-04-27 17:40:54]

Patchset #3 (id:60001) has been deleted

[Xi Han, 2015-04-27 17:41:34]

Hi Devlin: a test is added, PTAL, thanks.

[Xi Han, 2015-04-27 17:42:47]

hanxi@chromium.org changed reviewers:
+ xiyuan@chromium.org

[Xi Han, 2015-04-27 17:42:47]

+xiyuan@chromium.org: Please review changes in 

-chrome/browser/ui/webui/webui_webview_browsertest.cc

Thanks.

[xiyuan, 2015-04-27 17:43:36]

webui_webview_browsertest.cc LGTM

[Devlin, 2015-04-27 17:55:56]

lgtm

https://codereview.chromium.org/1062963006/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/webui_webview_browsertest.cc (right):

https://codereview.chromium.org/1062963006/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/webui_webview_browsertest.cc:138:
IN_PROC_BROWSER_TEST_F(WebUIWebViewBrowserTest, AddContentScriptIncognito) {
Awesome.

Can you:
- Put a comment saying that, right now, we only have incognito WebUI on CrOS,
but that this should theoretically work for all platforms
- Check that this did indeed fail before this patch?

[Xi Han, 2015-04-27 18:15:57]

Patchset #4 (id:100001) has been deleted

[Xi Han, 2015-04-27 18:17:48]

https://codereview.chromium.org/1062963006/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/webui_webview_browsertest.cc (right):

https://codereview.chromium.org/1062963006/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/webui_webview_browsertest.cc:138:
IN_PROC_BROWSER_TEST_F(WebUIWebViewBrowserTest, AddContentScriptIncognito) {
On 2015/04/27 17:55:56, Devlin wrote:
> Awesome.
> 
> Can you:
> - Put a comment saying that, right now, we only have incognito WebUI on CrOS,
> but that this should theoretically work for all platforms
> - Check that this did indeed fail before this patch?

Added. Yes, I modified other tests, which are in incognito mode and navigate to
other url like chrome://about/, and let them navigate to chrome://chrome-signin,
they do failed.

[Xi Han, 2015-04-27 18:17:53]

The CQ bit was checked by hanxi@chromium.org

[Xi Han, 2015-04-27 18:17:54]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1062963006/#ps120001
(title: "Comments")

[commit-bot: I haz the power, 2015-04-27 18:19:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062963006/120001

[commit-bot: I haz the power, 2015-04-27 19:09:13]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2015-04-27 19:10:58]

Patchset 4 (id:??) landed as
https://crrev.com/6233f60f246f03cd193bd9ecebbeb314813406d8
Cr-Commit-Position: refs/heads/master@{#327096}