Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1062963002: Updating App Remoting build files to include an OAuth2 client ID and manifest key which we will set… (Closed)

Created:
5 years, 8 months ago by joedow
Modified:
5 years, 8 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating App Remoting build files to include an OAuth2 client ID and manifest key which we will set in the manifest at build time. This removes the need to run any scripts before uploading to the webstore. Chromoting updates will be handled in a subsequent change (TODO added). Also made a few changes to handle the new prod_testing environment. BUG= Committed: https://crrev.com/ae2804289a728d5be2172f83e5e3ba6a428280aa Cr-Commit-Position: refs/heads/master@{#324067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -17 lines) Patch
M remoting/app_remoting_webapp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/app_remoting_webapp_build.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/remoting_options.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/webapp/build-webapp.py View 11 chunks +38 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
joedow
This changes updates the app remoting build mechanism to pull the OAuth2 client id and ...
5 years, 8 months ago (2015-04-07 01:22:28 UTC) #2
garykac
lgtm
5 years, 8 months ago (2015-04-07 17:22:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062963002/1
5 years, 8 months ago (2015-04-07 17:53:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 17:57:48 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 17:58:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae2804289a728d5be2172f83e5e3ba6a428280aa
Cr-Commit-Position: refs/heads/master@{#324067}

Powered by Google App Engine
This is Rietveld 408576698