Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1062913005: Push API: Deflake PushEventEnforcesUserVisibleNotification (Closed)

Created:
5 years, 8 months ago by johnme
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mvanouwerkerk+watch_chromium.org, peter+watch_chromium.org, johnme+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bindcurrent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Push API: Deflake PushEventEnforcesUserVisibleNotification PushMessagingBrowserTest.PushEventEnforcesUserVisibleNotification is flaky, because it doesn't wait for RequireUserVisibleUX etc to finish when it runs OnMessage. This patch fixes that. BUG=480413 Committed: https://crrev.com/7c9c8d3f85b293c4abc5a90b1b2247dc13e24479 Cr-Commit-Position: refs/heads/master@{#326796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -13 lines) Patch
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 7 chunks +19 lines, -6 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.h View 4 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 9 chunks +30 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
johnme
5 years, 8 months ago (2015-04-23 13:59:34 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 8 months ago (2015-04-24 12:28:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062913005/1
5 years, 8 months ago (2015-04-24 14:03:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 14:56:54 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 14:58:44 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7c9c8d3f85b293c4abc5a90b1b2247dc13e24479
Cr-Commit-Position: refs/heads/master@{#326796}

Powered by Google App Engine
This is Rietveld 408576698