Issue 1062913004: [refactor] kick some stuff out of js_codegen.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1062913004: [refactor] kick some stuff out of js_codegen.dart (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly

Modified:
5 years, 8 months ago

Reviewers:
Jacob

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

[refactor] kick some stuff out of js_codegen.dart the potentiallyMutated stuff goes into side_effect_analysis printing stuff goes into js_printer R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/88b8462ebb9a0dd5026652ce39490466f149b4aa

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+203 lines, -177 lines)			Patch
M	lib/src/codegen/js_codegen.dart	View	6 chunks	+8 lines, -177 lines	0 comments	Download
A	lib/src/codegen/js_printer.dart	View	1 chunk	+109 lines, -0 lines	0 comments	Download
A	lib/src/codegen/side_effect_analysis.dart	View	1 chunk	+86 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

there should be no functional changes here, just new signature for writeJsLibrary and writeNodeToContext

5 years, 8 months ago (2015-04-16 18:08:06 UTC) #2

Jennifer Messerly

5 years, 8 months ago (2015-04-16 18:15:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
88b8462ebb9a0dd5026652ce39490466f149b4aa (presubmit successful).