Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart

Issue 1062913003: Extract CallStructure from Selector. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter; 5 part of dart2js.js_emitter;
6 6
7 class ClassEmitter extends CodeEmitterHelper { 7 class ClassEmitter extends CodeEmitterHelper {
8 8
9 ClassStubGenerator get _stubGenerator => 9 ClassStubGenerator get _stubGenerator =>
10 new ClassStubGenerator(compiler, namer, backend); 10 new ClassStubGenerator(compiler, namer, backend);
(...skipping 30 matching lines...) Expand all
41 emitInstanceMembers(cls, builder); 41 emitInstanceMembers(cls, builder);
42 emitStubs(cls.callStubs, builder); 42 emitStubs(cls.callStubs, builder);
43 emitStubs(cls.typeVariableReaderStubs, builder); 43 emitStubs(cls.typeVariableReaderStubs, builder);
44 emitRuntimeTypeInformation(cls, builder); 44 emitRuntimeTypeInformation(cls, builder);
45 emitNativeInfo(cls, builder); 45 emitNativeInfo(cls, builder);
46 46
47 if (classElement == backend.closureClass) { 47 if (classElement == backend.closureClass) {
48 // We add a special getter here to allow for tearing off a closure from 48 // We add a special getter here to allow for tearing off a closure from
49 // itself. 49 // itself.
50 jsAst.Fun function = js('function() { return this; }'); 50 jsAst.Fun function = js('function() { return this; }');
51 String name = namer.getterForPublicMember(Compiler.CALL_OPERATOR_NAME); 51 String name = namer.getterForMember(Selector.CALL_NAME);
52 builder.addProperty(name, function); 52 builder.addProperty(name, function);
53 } 53 }
54 54
55 emitClassBuilderWithReflectionData(cls, builder, enclosingBuilder); 55 emitClassBuilderWithReflectionData(cls, builder, enclosingBuilder);
56 } 56 }
57 /** 57 /**
58 * Emits the precompiled constructor when in CSP mode. 58 * Emits the precompiled constructor when in CSP mode.
59 */ 59 */
60 void emitConstructorsForCSP(Class cls) { 60 void emitConstructorsForCSP(Class cls) {
61 List<String> fieldNames = <String>[]; 61 List<String> fieldNames = <String>[];
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 assert(container is Library); 96 assert(container is Library);
97 assert(emitStatics); 97 assert(emitStatics);
98 fields = container.staticFieldsForReflection; 98 fields = container.staticFieldsForReflection;
99 } 99 }
100 100
101 var fieldMetadata = []; 101 var fieldMetadata = [];
102 bool hasMetadata = false; 102 bool hasMetadata = false;
103 bool fieldsAdded = false; 103 bool fieldsAdded = false;
104 104
105 for (Field field in fields) { 105 for (Field field in fields) {
106 VariableElement fieldElement = field.element; 106 FieldElement fieldElement = field.element;
107 String name = field.name; 107 String name = field.name;
108 String accessorName = field.accessorName; 108 String accessorName = field.accessorName;
109 bool needsGetter = field.needsGetter; 109 bool needsGetter = field.needsGetter;
110 bool needsSetter = field.needsUncheckedSetter; 110 bool needsSetter = field.needsUncheckedSetter;
111 111
112 // Ignore needsCheckedSetter - that is handled below. 112 // Ignore needsCheckedSetter - that is handled below.
113 bool needsAccessor = (needsGetter || needsSetter); 113 bool needsAccessor = (needsGetter || needsSetter);
114 // We need to output the fields for non-native classes so we can auto- 114 // We need to output the fields for non-native classes so we can auto-
115 // generate the constructor. For native classes there are no 115 // generate the constructor. For native classes there are no
116 // constructors, so we don't need the fields unless we are generating 116 // constructors, so we don't need the fields unless we are generating
117 // accessors at runtime. 117 // accessors at runtime.
118 bool needsFieldsForConstructor = !emitStatics && !classIsNative; 118 bool needsFieldsForConstructor = !emitStatics && !classIsNative;
119 if (needsFieldsForConstructor || needsAccessor) { 119 if (needsFieldsForConstructor || needsAccessor) {
120 var metadata = 120 var metadata =
121 task.metadataCollector.buildMetadataFunction(fieldElement); 121 task.metadataCollector.buildMetadataFunction(fieldElement);
122 if (metadata != null) { 122 if (metadata != null) {
123 hasMetadata = true; 123 hasMetadata = true;
124 } else { 124 } else {
125 metadata = new jsAst.LiteralNull(); 125 metadata = new jsAst.LiteralNull();
126 } 126 }
127 fieldMetadata.add(metadata); 127 fieldMetadata.add(metadata);
128 recordMangledField(fieldElement, accessorName, 128 recordMangledField(fieldElement, accessorName,
129 namer.privateName(fieldElement.library, fieldElement.name)); 129 namer.privateName(fieldElement.memberName));
130 String fieldName = name; 130 String fieldName = name;
131 String fieldCode = ''; 131 String fieldCode = '';
132 String reflectionMarker = ''; 132 String reflectionMarker = '';
133 if (!needsAccessor) { 133 if (!needsAccessor) {
134 // Emit field for constructor generation. 134 // Emit field for constructor generation.
135 assert(!classIsNative); 135 assert(!classIsNative);
136 } else { 136 } else {
137 // Emit (possibly renaming) field name so we can add accessors at 137 // Emit (possibly renaming) field name so we can add accessors at
138 // runtime. 138 // runtime.
139 if (name != accessorName) { 139 if (name != accessorName) {
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 } else { 369 } else {
370 throw new SpannableAssertionFailure( 370 throw new SpannableAssertionFailure(
371 element, 'Expected a ClassElement or a LibraryElement.'); 371 element, 'Expected a ClassElement or a LibraryElement.');
372 } 372 }
373 373
374 // If the class is never instantiated we still need to set it up for 374 // If the class is never instantiated we still need to set it up for
375 // inheritance purposes, but we can simplify its JavaScript constructor. 375 // inheritance purposes, but we can simplify its JavaScript constructor.
376 bool isInstantiated = 376 bool isInstantiated =
377 compiler.codegenWorld.directlyInstantiatedClasses.contains(element); 377 compiler.codegenWorld.directlyInstantiatedClasses.contains(element);
378 378
379 void visitField(Element holder, VariableElement field) { 379 void visitField(Element holder, FieldElement field) {
380 assert(invariant(element, field.isDeclaration)); 380 assert(invariant(element, field.isDeclaration));
381 String name = field.name; 381 String name = field.name;
382 382
383 // Keep track of whether or not we're dealing with a field mixin 383 // Keep track of whether or not we're dealing with a field mixin
384 // into a native class. 384 // into a native class.
385 bool isMixinNativeField = 385 bool isMixinNativeField =
386 isClass && element.isNative && holder.isMixinApplication; 386 isClass && element.isNative && holder.isMixinApplication;
387 387
388 // See if we can dynamically create getters and setters. 388 // See if we can dynamically create getters and setters.
389 // We can only generate getters and setters for [element] since 389 // We can only generate getters and setters for [element] since
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
544 ? new Selector.getter(member.name, member.library) 544 ? new Selector.getter(member.name, member.library)
545 : new Selector.setter(member.name, member.library); 545 : new Selector.setter(member.name, member.library);
546 String reflectionName = emitter.getReflectionName(selector, name); 546 String reflectionName = emitter.getReflectionName(selector, name);
547 if (reflectionName != null) { 547 if (reflectionName != null) {
548 var reflectable = 548 var reflectable =
549 js(backend.isAccessibleByReflection(member) ? '1' : '0'); 549 js(backend.isAccessibleByReflection(member) ? '1' : '0');
550 builder.addProperty('+$reflectionName', reflectable); 550 builder.addProperty('+$reflectionName', reflectable);
551 } 551 }
552 } 552 }
553 } 553 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698