Remove checks in fxge/{apple,win32,skia,dib} now that FX_NEW cant return 0

core/src/fxge/dib/fx_dib_main.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fxge/fx_dib.h"
 #include "../../../include/fxge/fx_ge.h"
 #include "../../../include/fxcodec/fx_codec.h"
 #include "dib_int.h"
@@ skipping 146 matching lines @@
 }
 CFX_DIBitmap* CFX_DIBSource::Clone(const FX_RECT* pClip) const
 {
     FX_RECT rect(0, 0, m_Width, m_Height);
     if (pClip) {
         rect.Intersect(*pClip);
         if (rect.IsEmpty()) {
             return NULL;
         }
     }
-    CFX_DIBitmap* pNewBitmap = FX_NEW CFX_DIBitmap;
-    if (!pNewBitmap) {
-        return NULL;
-    }
+    CFX_DIBitmap* pNewBitmap = new CFX_DIBitmap;
     if (!pNewBitmap->Create(rect.Width(), rect.Height(), GetFormat())) {
         delete pNewBitmap;
         return NULL;
     }
     pNewBitmap->CopyPalette(m_pPalette);
     pNewBitmap->CopyAlphaMask(m_pAlphaMask, pClip);
     if (GetBPP() == 1 && rect.left % 8 != 0) {
         int left_shift = rect.left % 32;
         int right_shift = 32 - left_shift;
         int dword_count = pNewBitmap->m_Pitch / 4;
@@ skipping 48 matching lines @@
                 m_pPalette[i] = 0xff000000 | (i * 0x10101);
             }
         }
     }
 }
 FX_BOOL CFX_DIBSource::BuildAlphaMask()
 {
     if (m_pAlphaMask) {
         return TRUE;
     }
-    m_pAlphaMask = FX_NEW CFX_DIBitmap;
-    if (!m_pAlphaMask) {
-        return FALSE;
-    }
+    m_pAlphaMask = new CFX_DIBitmap;
     if (!m_pAlphaMask->Create(m_Width, m_Height, FXDIB_8bppMask)) {
         delete m_pAlphaMask;
         m_pAlphaMask = NULL;
         return FALSE;
     }
     FXSYS_memset8(m_pAlphaMask->GetBuffer(), 0xff, m_pAlphaMask->GetHeight()*m_pAlphaMask->GetPitch());
     return TRUE;
 }
 FX_DWORD CFX_DIBSource::GetPaletteEntry(int index) const
 {
@@ skipping 314 matching lines @@
 CFX_DIBitmap* CFX_DIBSource::GetAlphaMask(const FX_RECT* pClip) const
 {
     ASSERT(GetFormat() == FXDIB_Argb);
     FX_RECT rect(0, 0, m_Width, m_Height);
     if (pClip) {
         rect.Intersect(*pClip);
         if (rect.IsEmpty()) {
             return NULL;
         }
     }
-    CFX_DIBitmap* pMask = FX_NEW CFX_DIBitmap;
-    if (!pMask) {
-        return NULL;
-    }
+    CFX_DIBitmap* pMask = new CFX_DIBitmap;
     if (!pMask->Create(rect.Width(), rect.Height(), FXDIB_8bppMask)) {
         delete pMask;
         return NULL;
     }
     for (int row = rect.top; row < rect.bottom; row ++) {
         FX_LPCBYTE src_scan = GetScanline(row) + rect.left * 4 + 3;
         FX_LPBYTE dest_scan = (FX_LPBYTE)pMask->GetScanline(row - rect.top);
         for (int col = rect.left; col < rect.right; col ++) {
             *dest_scan ++ = *src_scan;
             src_scan += 4;
@@ skipping 304 matching lines @@
                 if (m_pPalette == NULL) {
                     return FALSE;
                 }
                 FX_BYTE gray[2];
                 for (int i = 0; i < 2; i ++) {
                     int r = (FX_BYTE)(m_pPalette[i] >> 16);
                     int g = (FX_BYTE)(m_pPalette[i] >> 8);
                     int b = (FX_BYTE)m_pPalette[i];
                     gray[i] = (FX_BYTE)FXRGB2GRAY(r, g, b);
                 }
-                CFX_DIBitmap* pMask = FX_NEW CFX_DIBitmap;
-                if (!pMask) {
-                    return FALSE;
-                }
+                CFX_DIBitmap* pMask = new CFX_DIBitmap;
                 if (!pMask->Create(m_Width, m_Height, FXDIB_8bppMask)) {
                     delete pMask;
                     return FALSE;
                 }
                 FXSYS_memset8(pMask->GetBuffer(), gray[0], pMask->GetPitch() * m_Height);
                 for (int row = 0; row < m_Height; row ++) {
                     FX_LPBYTE src_pos = m_pBuffer + row * m_Pitch;
                     FX_LPBYTE dest_pos = (FX_LPBYTE)pMask->GetScanline(row);
                     for (int col = 0; col < m_Width; col ++) {
                         if (src_pos[col / 8] & (1 << (7 - col % 8))) {
@@ skipping 10 matching lines @@
                 if (m_pPalette == NULL) {
                     return FALSE;
                 }
                 FX_BYTE gray[256];
                 for (int i = 0; i < 256; i ++) {
                     int r = (FX_BYTE)(m_pPalette[i] >> 16);
                     int g = (FX_BYTE)(m_pPalette[i] >> 8);
                     int b = (FX_BYTE)m_pPalette[i];
                     gray[i] = (FX_BYTE)FXRGB2GRAY(r, g, b);
                 }
-                CFX_DIBitmap* pMask = FX_NEW CFX_DIBitmap;
-                if (!pMask) {
-                    return FALSE;
-                }
+                CFX_DIBitmap* pMask = new CFX_DIBitmap;
                 if (!pMask->Create(m_Width, m_Height, FXDIB_8bppMask)) {
                     delete pMask;
                     return FALSE;
                 }
                 for (int row = 0; row < m_Height; row ++) {
                     FX_LPBYTE dest_pos = pMask->GetBuffer() + row * pMask->GetPitch();
                     FX_LPBYTE src_pos = m_pBuffer + row * m_Pitch;
                     for (int col = 0; col < m_Width; col ++) {
                         *dest_pos ++ = gray[*src_pos ++];
                     }
                 }
                 TakeOver(pMask);
                 delete pMask;
                 break;
             }
         case FXDIB_Rgb: {
-                CFX_DIBitmap* pMask = FX_NEW CFX_DIBitmap;
-                if (!pMask) {
-                    return FALSE;
-                }
+                CFX_DIBitmap* pMask = new CFX_DIBitmap;
                 if (!pMask->Create(m_Width, m_Height, FXDIB_8bppMask)) {
                     delete pMask;
                     return FALSE;
                 }
                 for (int row = 0; row < m_Height; row ++) {
                     FX_LPBYTE src_pos = m_pBuffer + row * m_Pitch;
                     FX_LPBYTE dest_pos = pMask->GetBuffer() + row * pMask->GetPitch();
                     for (int col = 0; col < m_Width; col ++) {
                         *dest_pos ++ = FXRGB2GRAY(src_pos[2], src_pos[1], *src_pos);
                         src_pos += 3;
                     }
                 }
                 TakeOver(pMask);
                 delete pMask;
                 break;
             }
         case FXDIB_Rgb32: {
-                CFX_DIBitmap* pMask = FX_NEW CFX_DIBitmap;
-                if (!pMask) {
-                    return FALSE;
-                }
+                CFX_DIBitmap* pMask = new CFX_DIBitmap;
                 if (!pMask->Create(m_Width, m_Height, FXDIB_8bppMask)) {
                     delete pMask;
                     return FALSE;
                 }
                 for (int row = 0; row < m_Height; row ++) {
                     FX_LPBYTE src_pos = m_pBuffer + row * m_Pitch;
                     FX_LPBYTE dest_pos = pMask->GetBuffer() + row * pMask->GetPitch();
                     for (int col = 0; col < m_Width; col ++) {
                         *dest_pos ++ = FXRGB2GRAY(src_pos[2], src_pos[1], *src_pos);
                         src_pos += 4;
@@ skipping 413 matching lines @@
                 } else {
                     next_scan[col - 1] = src;
                 }
             }
         }
     }
     return TRUE;
 }
 CFX_DIBitmap* CFX_DIBSource::FlipImage(FX_BOOL bXFlip, FX_BOOL bYFlip) const
 {
-    CFX_DIBitmap* pFlipped = FX_NEW CFX_DIBitmap;
-    if (!pFlipped) {
-        return NULL;
-    }
+    CFX_DIBitmap* pFlipped = new CFX_DIBitmap;
     if (!pFlipped->Create(m_Width, m_Height, GetFormat())) {
         delete pFlipped;
         return NULL;
     }
     pFlipped->CopyPalette(m_pPalette);
     FX_LPBYTE pDestBuffer = pFlipped->GetBuffer();
     int Bpp = m_bpp / 8;
     for (int row = 0; row < m_Height; row ++) {
         FX_LPCBYTE src_scan = GetScanline(row);
         FX_LPBYTE dest_scan = pDestBuffer + m_Pitch * (bYFlip ? (m_Height - row - 1) : row);
@@ skipping 53 matching lines @@
         }
     }
     return pFlipped;
 }
 CFX_DIBExtractor::CFX_DIBExtractor(const CFX_DIBSource* pSrc)
 {
     m_pBitmap = NULL;
     if (pSrc->GetBuffer() == NULL) {
         m_pBitmap = pSrc->Clone();
     } else {
-        m_pBitmap = FX_NEW CFX_DIBitmap;
-        if (!m_pBitmap) {
-            return;
-        }
+        m_pBitmap = new CFX_DIBitmap;
         if (!m_pBitmap->Create(pSrc->GetWidth(), pSrc->GetHeight(), pSrc->GetFormat(), pSrc->GetBuffer())) {
             delete m_pBitmap;
             m_pBitmap = NULL;
             return;
         }
         m_pBitmap->CopyPalette(pSrc->GetPalette());
         m_pBitmap->CopyAlphaMask(pSrc->m_pAlphaMask);
     }
 }
 CFX_DIBExtractor::~CFX_DIBExtractor()
@@ skipping 90 matching lines @@
             bitmap_clip = _FXDIB_SwapClipBox(bitmap_clip, dest_width, dest_height, m_Matrix.c > 0, m_Matrix.b < 0);
             m_Composer.Compose(pDevice, pClipRgn, bitmap_alpha, mask_color, m_ClipBox, TRUE,
                                m_Matrix.c > 0, m_Matrix.b < 0, m_bRgbByteOrder, alpha_flag, pIccTransform, m_BlendType);
             if (!m_Stretcher.Start(&m_Composer, pSource, dest_height, dest_width, bitmap_clip, dib_flags)) {
                 return FALSE;
             }
             m_Status = 1;
             return TRUE;
         }
         m_Status = 2;
-        m_pTransformer = FX_NEW CFX_ImageTransformer;
-        if (!m_pTransformer) {
-            return FALSE;
-        }
+        m_pTransformer = new CFX_ImageTransformer;
         m_pTransformer->Start(pSource, &m_Matrix, dib_flags, &m_ClipBox);
         return TRUE;
     }
     int dest_width = image_rect.Width();
     if (m_Matrix.a < 0) {
         dest_width = -dest_width;
     }
     int dest_height = image_rect.Height();
     if (m_Matrix.d > 0) {
         dest_height = -dest_height;
@@ skipping 78 matching lines @@
                                (FX_LPBYTE)m_pBitmap->m_pAlphaMask->GetScanline(line) : NULL;
     if (dest_buf) {
         FXSYS_memcpy32(dest_buf, scanline, m_pBitmap->GetPitch());
     }
     if (dest_alpha_buf) {
         FXSYS_memcpy32(dest_alpha_buf, scan_extra_alpha, m_pBitmap->m_pAlphaMask->GetPitch());
     }
 }
 FX_BOOL CFX_BitmapStorer::SetInfo(int width, int height, FXDIB_Format src_format, FX_DWORD* pSrcPalette)
 {
-    m_pBitmap = FX_NEW CFX_DIBitmap;
-    if (!m_pBitmap) {
-        return FALSE;
-    }
+    m_pBitmap = new CFX_DIBitmap;
     if (!m_pBitmap->Create(width, height, src_format)) {
         delete m_pBitmap;
         m_pBitmap = NULL;
         return FALSE;
     }
     if (pSrcPalette) {
         m_pBitmap->CopyPalette(pSrcPalette);
     }
     return TRUE;
 }