Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1062853004: Remove unused constants and functions from Files app. (Closed)

Created:
5 years, 8 months ago by mtomasz
Modified:
5 years, 8 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused constants and functions from Files app. TEST=Compiles and all current tests pass. BUG=None Committed: https://crrev.com/4882adfdf046e2a17b4ec3e2457609ef591cdc71 Cr-Commit-Position: refs/heads/master@{#324011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_util.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/file_manager_private.idl View 2 chunks +2 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/background/js/volume_manager.js View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/common/js/volume_manager_common.js View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtomasz
@hirono: PTAL. Thanks.
5 years, 8 months ago (2015-04-07 02:12:33 UTC) #2
hirono
On 2015/04/07 02:12:33, mtomasz wrote: > @hirono: PTAL. Thanks. Thank you! lgtm!
5 years, 8 months ago (2015-04-07 03:09:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062853004/1
5 years, 8 months ago (2015-04-07 03:10:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 03:44:00 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 03:44:57 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4882adfdf046e2a17b4ec3e2457609ef591cdc71
Cr-Commit-Position: refs/heads/master@{#324011}

Powered by Google App Engine
This is Rietveld 408576698