Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1062823004: Fix a couple codegen crashers (Closed)

Created:
5 years, 8 months ago by vsm
Modified:
5 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase tests #

Total comments: 5

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -5 lines) Patch
M lib/src/codegen/js_codegen.dart View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M test/codegen/cascade.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M test/codegen/expect/cascade.js View 1 2 chunks +10 lines, -0 lines 0 comments Download
M test/codegen/expect/cascade.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M test/codegen/expect/try_catch.js View 1 2 2 chunks +15 lines, -1 line 0 comments Download
M test/codegen/try_catch.dart View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vsm
5 years, 8 months ago (2015-04-10 19:46:14 UTC) #2
vsm
On 2015/04/10 19:46:14, vsm wrote: Ugh - the side-by-side diffs aren't showing. The unified ones ...
5 years, 8 months ago (2015-04-10 19:46:53 UTC) #3
Jennifer Messerly
lgtm except for .realTarget https://codereview.chromium.org/1062823004/diff/20001/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/1062823004/diff/20001/lib/src/codegen/js_codegen.dart#newcode1763 lib/src/codegen/js_codegen.dart:1763: _bindValue(scope, 'o', prop.realTarget, context: context), ...
5 years, 8 months ago (2015-04-10 20:32:34 UTC) #4
vsm
https://codereview.chromium.org/1062823004/diff/20001/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/1062823004/diff/20001/lib/src/codegen/js_codegen.dart#newcode1763 lib/src/codegen/js_codegen.dart:1763: _bindValue(scope, 'o', prop.realTarget, context: context), On 2015/04/10 20:32:33, John ...
5 years, 8 months ago (2015-04-10 20:41:35 UTC) #5
vsm
5 years, 8 months ago (2015-04-10 20:41:52 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
6f04c361449b9d52566904ed8860b9af8549dc2a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698