Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: pkg/analysis_server/test/services/correction/assist_test.dart

Issue 1062823002: Issue 13239. Add the 'Encapsulate Field' refactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/assist_internal.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/correction/assist_test.dart
diff --git a/pkg/analysis_server/test/services/correction/assist_test.dart b/pkg/analysis_server/test/services/correction/assist_test.dart
index 9d36c59b7b89783b6025e21c1569fa4cec99aa86..bdebc7fecb547762633585a0d5612883fcb4982f 100644
--- a/pkg/analysis_server/test/services/correction/assist_test.dart
+++ b/pkg/analysis_server/test/services/correction/assist_test.dart
@@ -1290,6 +1290,28 @@ main(String str) {
''');
}
+ void test_convertToIsNotEmpty_wrong_noBang() {
+ verifyNoTestUnitErrors = false;
+ resolveTestUnit('''
+main(String str) {
+ ~str.isEmpty;
+}
+''');
+ assertNoAssistAt('isEmpty;', AssistKind.CONVERT_INTO_IS_NOT_EMPTY);
+ }
+
+ void test_convertToIsNotEmpty_wrong_noIsNotEmpty() {
+ resolveTestUnit('''
+class A {
+ bool get isEmpty => false;
+}
+main(A a) {
+ !a.isEmpty;
+}
+''');
+ assertNoAssistAt('isEmpty;', AssistKind.CONVERT_INTO_IS_NOT_EMPTY);
+ }
+
void test_convertToIsNotEmpty_wrong_notInPrefixExpression() {
resolveTestUnit('''
main(String str) {
@@ -1308,16 +1330,91 @@ main(int p) {
assertNoAssistAt('isEven;', AssistKind.CONVERT_INTO_IS_NOT_EMPTY);
}
- void test_convertToIsNotEmpty_wrote_noIsNotEmpty() {
+ void test_encapsulateField_BAD_alreadyPrivate() {
resolveTestUnit('''
class A {
- bool get isEmpty => false;
+ int _test = 42;
}
main(A a) {
- !a.isEmpty;
+ print(a._test);
+}
+''');
+ assertNoAssistAt('_test =', AssistKind.ENCAPSULATE_FIELD);
+ }
+
+ void test_encapsulateField_BAD_multipleFields() {
+ resolveTestUnit('''
+class A {
+ int aaa, bbb, ccc;
+}
+main(A a) {
+ print(a.bbb);
+}
+''');
+ assertNoAssistAt('bbb, ', AssistKind.ENCAPSULATE_FIELD);
+ }
+
+ void test_encapsulateField_BAD_parseError() {
+ verifyNoTestUnitErrors = false;
+ resolveTestUnit('''
+class A {
+ int; // marker
+}
+main(A a) {
+ print(a.test);
+}
+''');
+ assertNoAssistAt('; // marker', AssistKind.ENCAPSULATE_FIELD);
+ }
+
+ void test_encapsulateField_OK_hasType() {
+ resolveTestUnit('''
+class A {
+ int test = 42;
+}
+main(A a) {
+ print(a.test);
+}
+''');
+ assertHasAssistAt('test = 42', AssistKind.ENCAPSULATE_FIELD, '''
+class A {
+ int _test = 42;
+
+ int get test => _test;
+
+ void set test(int test) {
+ _test = test;
+ }
+}
+main(A a) {
+ print(a.test);
+}
+''');
+ }
+
+ void test_encapsulateField_OK_noType() {
+ resolveTestUnit('''
+class A {
+ var test = 42;
+}
+main(A a) {
+ print(a.test);
+}
+''');
+ assertHasAssistAt('test = 42', AssistKind.ENCAPSULATE_FIELD, '''
+class A {
+ var _test = 42;
+
+ get test => _test;
+
+ void set test(test) {
+ _test = test;
+ }
+}
+main(A a) {
+ print(a.test);
}
''');
- assertNoAssistAt('isEmpty;', AssistKind.CONVERT_INTO_IS_NOT_EMPTY);
}
void test_exchangeBinaryExpressionArguments_OK_compare() {
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/assist_internal.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698