If shadow DOM is not supported, search for i18n attributes without using the /deep/ selector.

If shadow DOM is not supported, search for i18n attributes without using the /deep/ selector.

This fixes an issue where Chrome on iOS failed to translate interstitial pages due to use of this selector (on iOS, Chrome uses UIWebView which does not have native support for shadow DOM).

Note that Polymer-based pages will still work in iOS WebUI pages because /deep/ will be polyfilled.

BUG=474360
Committed: https://crrev.com/0a1bc58020bbafa7ee80a7990cc6b89acb1d21e9
Cr-Commit-Position: refs/heads/master@{#324179}

[Kyle Horimoto, 2015-04-07 01:28:59]

khorimoto@chromium.org changed reviewers:
+ jhawkins@chromium.org

[James Hawkins, 2015-04-07 15:14:48]

Is this still necessary?

[Kyle Horimoto, 2015-04-07 17:06:39]

On 2015/04/07 15:14:48, James Hawkins wrote:
> Is this still necessary?

Yes. This fixes an issue where Chrome on iOS failed to translate interstitial
pages due to use of this selector (on iOS, Chrome uses UIWebView which does not
have native support for shadow DOM). In this case, using the /deep/ selector
causes document.querySelectorAll() to fail and return 0 results.

[James Hawkins, 2015-04-07 17:09:56]

lgtm

[Kyle Horimoto, 2015-04-07 17:11:29]

The CQ bit was checked by khorimoto@chromium.org

[commit-bot: I haz the power, 2015-04-07 17:12:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062813007/20001

[commit-bot: I haz the power, 2015-04-07 19:04:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-07 19:04:58]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Kyle Horimoto, 2015-04-07 19:06:24]

The CQ bit was checked by khorimoto@chromium.org

[commit-bot: I haz the power, 2015-04-07 19:07:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062813007/20001

[commit-bot: I haz the power, 2015-04-07 20:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-07 20:22:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Kyle Horimoto, 2015-04-07 20:25:32]

The CQ bit was checked by khorimoto@chromium.org

[commit-bot: I haz the power, 2015-04-07 20:26:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062813007/20001

[commit-bot: I haz the power, 2015-04-07 21:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-07 21:12:39]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Kyle Horimoto, 2015-04-07 22:10:30]

The CQ bit was checked by khorimoto@chromium.org

[Kyle Horimoto, 2015-04-07 22:10:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
jhawkins@chromium.org
Link to the patchset: https://codereview.chromium.org/1062813007/#ps40001
(title: "Use parentheses for the ternary operator.")

[commit-bot: I haz the power, 2015-04-07 22:10:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062813007/40001

[commit-bot: I haz the power, 2015-04-08 00:30:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-08 00:30:57]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Kyle Horimoto, 2015-04-08 01:12:00]

The CQ bit was checked by khorimoto@chromium.org

[Kyle Horimoto, 2015-04-08 01:12:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
jhawkins@chromium.org
Link to the patchset: https://codereview.chromium.org/1062813007/#ps60001
(title: "Add existence check for window.document.body before
window.document.body.createShadowRoot.")

[commit-bot: I haz the power, 2015-04-08 01:12:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062813007/60001

[commit-bot: I haz the power, 2015-04-08 02:37:50]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-08 02:38:33]

Patchset 4 (id:??) landed as
https://crrev.com/0a1bc58020bbafa7ee80a7990cc6b89acb1d21e9
Cr-Commit-Position: refs/heads/master@{#324179}

[Dan Beam, 2015-06-23 23:33:11]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-06-23 23:33:12]

https://codereview.chromium.org/1062813007/diff/60001/ui/webui/resources/js/i...
File ui/webui/resources/js/i18n_template_no_process.js (right):

https://codereview.chromium.org/1062813007/diff/60001/ui/webui/resources/js/i...
ui/webui/resources/js/i18n_template_no_process.js:120: 'html /deep/ [' +
attributeNames.join('],[') + ']' :
so this is whining in the console now about /deep/ being deprecated:

  /deep/ combinator is deprecated. See
https://www.chromestatus.com/features/6750456638341120 for more details.