views: Use ClipTransformRecorder to access canvas in ProfileChooserView

views: Use ClipTransformRecorder to access canvas in ProfileChooserView

Go through a recorder instead of getting the canvas() from the
PaintContext, so this will continue to work when the PaintContext
is backed by a DisplayItemList instead of a canvas.

R=sky
BUG=466426
Committed: https://crrev.com/a3084d7ed40ed48ff0da9d6ba5048debe8af5e82
Cr-Commit-Position: refs/heads/master@{#323965}

[danakj, 2015-04-06 17:51:03]

Rather than add infinity constructors to ClipTransformRecorder, I've moved the
clip/transform ops to individual methods.

[danakj, 2015-04-06 21:19:47]

danakj@chromium.org changed reviewers:
+ piman@chromium.org, pkasting@google.com, sadrul@chromium.org

[danakj, 2015-04-06 21:19:48]

It looks like sky is out atm.

pkasting can you review chrome/ please?
sadrul ui/views please?
piman ui/compositor please?

[piman, 2015-04-06 21:24:02]

lgtm

https://codereview.chromium.org/1062813004/diff/1/ui/compositor/clip_transfor...
File ui/compositor/clip_transform_recorder.h (right):

https://codereview.chromium.org/1062813004/diff/1/ui/compositor/clip_transfor...
ui/compositor/clip_transform_recorder.h:28: ClipTransformRecorder(const
PaintContext& context);
nit: explicit

[danakj, 2015-04-06 21:25:34]

https://codereview.chromium.org/1062813004/diff/1/ui/compositor/clip_transfor...
File ui/compositor/clip_transform_recorder.h (right):

https://codereview.chromium.org/1062813004/diff/1/ui/compositor/clip_transfor...
ui/compositor/clip_transform_recorder.h:28: ClipTransformRecorder(const
PaintContext& context);
On 2015/04/06 21:24:01, piman (Very slow to review) wrote:
> nit: explicit

good eye :) thanks, done.

[sadrul, 2015-04-06 22:21:14]

lgtm

[Peter Kasting, 2015-04-06 22:27:43]

LGTM

[danakj, 2015-04-06 22:27:55]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-04-06 22:27:56]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1062813004/#ps20001
(title: "profilechooser-recorder: explicit")

[commit-bot: I haz the power, 2015-04-06 22:28:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062813004/20001

[commit-bot: I haz the power, 2015-04-06 22:32:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-06 22:33:50]

Patchset 2 (id:??) landed as
https://crrev.com/a3084d7ed40ed48ff0da9d6ba5048debe8af5e82
Cr-Commit-Position: refs/heads/master@{#323965}