Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1062803009: Use of base::StringPairs appropriately in stats.h (Closed)

Created:
5 years, 7 months ago by payal.pandey
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use of base::StringPairs appropriately in stats.h Bescause base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/2315eba248a850a4fc012a52c0a3f0065916d663 Cr-Commit-Position: refs/heads/master@{#327240}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Incorporated review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/disk_cache/blockfile/stats.h View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
payal.pandey
Replaced typedef std::vector<std::pair<std::string, std::string> > with base::StringPairs Please have a look
5 years, 7 months ago (2015-04-27 07:15:12 UTC) #2
eroman
lgtm https://codereview.chromium.org/1062803009/diff/1/net/disk_cache/blockfile/stats.h File net/disk_cache/blockfile/stats.h (right): https://codereview.chromium.org/1062803009/diff/1/net/disk_cache/blockfile/stats.h#newcode21 net/disk_cache/blockfile/stats.h:21: typedef base::StringPairs StatsItems; same comment as on other ...
5 years, 7 months ago (2015-04-27 21:39:57 UTC) #3
payal.pandey
Updated the CL with feedback information using StatsItems = base::StringPairs; Thanks for feedback & lgtm.
5 years, 7 months ago (2015-04-28 05:35:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062803009/20001
5 years, 7 months ago (2015-04-28 05:36:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-28 06:37:53 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 06:38:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2315eba248a850a4fc012a52c0a3f0065916d663
Cr-Commit-Position: refs/heads/master@{#327240}

Powered by Google App Engine
This is Rietveld 408576698