Issue 1062803005: Removing 3 warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1062803005: Removing 3 warnings. (Closed)

Created:
5 years, 8 months ago by Mircea Trofin

Modified:
5 years, 8 months ago

Reviewers:
jvoung (off chromium), Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Removing 3 gcc warnings: - redundant ';' after namespace decls - mix of enums and integer values - use of && insteand of & for bitwise operations BUG=NONE R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=59c6f5a3b1960a9d42f703cf9f7846b59e57bc24

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
M	src/IceBrowserCompileServer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/IceClFlags.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/IceCompileServer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/IceTypes.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

Mircea Trofin

5 years, 8 months ago (2015-04-06 23:06:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
59c6f5a3b1960a9d42f703cf9f7846b59e57bc24 (presubmit successful).