Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8304)

Unified Diff: chrome/installer/util/logging_installer_unittest.cc

Issue 1062743006: Add installer_util_unittests to the GN windows build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wintests3
Patch Set: Fixes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/language_selector.cc ('k') | chrome/installer/util/master_preferences_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/logging_installer_unittest.cc
diff --git a/chrome/installer/util/logging_installer_unittest.cc b/chrome/installer/util/logging_installer_unittest.cc
index 910f35d1c1bd45819f5d1300d5ff1527c22cc54f..06b959a8b9c329e01fdb5b53a40de107ffa01b5c 100644
--- a/chrome/installer/util/logging_installer_unittest.cc
+++ b/chrome/installer/util/logging_installer_unittest.cc
@@ -20,7 +20,8 @@ TEST(LoggingInstallerTest, TestTruncate) {
base::FilePath temp_file = temp_dir.path().Append(L"temp");
EXPECT_EQ(test_data.size(),
- base::WriteFile(temp_file, &test_data[0], test_data.size()));
+ base::WriteFile(temp_file, &test_data[0],
+ static_cast<int>(test_data.size())));
ASSERT_TRUE(base::PathExists(temp_file));
int64 file_size = 0;
@@ -45,7 +46,8 @@ TEST(LoggingInstallerTest, TestTruncationNotNeeded) {
base::FilePath temp_file = temp_dir.path().Append(L"temp");
EXPECT_EQ(test_data.size(),
- base::WriteFile(temp_file, &test_data[0], test_data.size()));
+ base::WriteFile(temp_file, &test_data[0],
+ static_cast<int>(test_data.size())));
ASSERT_TRUE(base::PathExists(temp_file));
int64 file_size = 0;
@@ -67,7 +69,8 @@ TEST(LoggingInstallerTest, TestInUseNeedsTruncation) {
base::FilePath temp_file = temp_dir.path().Append(L"temp");
EXPECT_EQ(test_data.size(),
- base::WriteFile(temp_file, &test_data[0], test_data.size()));
+ base::WriteFile(temp_file, &test_data[0],
+ static_cast<int>(test_data.size())));
ASSERT_TRUE(base::PathExists(temp_file));
int64 file_size = 0;
EXPECT_TRUE(base::GetFileSize(temp_file, &file_size));
@@ -95,7 +98,8 @@ TEST(LoggingInstallerTest, TestMoveFailsNeedsTruncation) {
base::FilePath temp_file = temp_dir.path().Append(L"temp");
EXPECT_EQ(test_data.size(),
- base::WriteFile(temp_file, &test_data[0], test_data.size()));
+ base::WriteFile(temp_file, &test_data[0],
+ static_cast<int>(test_data.size())));
ASSERT_TRUE(base::PathExists(temp_file));
int64 file_size = 0;
EXPECT_TRUE(base::GetFileSize(temp_file, &file_size));
« no previous file with comments | « chrome/installer/util/language_selector.cc ('k') | chrome/installer/util/master_preferences_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698