Add installer_util_unittests to the GN windows build

Add installer_util_unittests to the GN windows build

This fixes some C++ Warnings on Windows to avoid having to add suppressions to the GN build.

Moves the generated strings header to the same place in the gen tree as it is in the source tree. Update includes.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Committed: https://crrev.com/cb55755a09b9e2d8c5b05b7a4ad2ff8631e15b13
Cr-Commit-Position: refs/heads/master@{#327790}

[brettw, 2015-04-29 22:29:35]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-29 22:30:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062743006/20001

[commit-bot: I haz the power, 2015-04-29 22:37:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-29 22:37:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-04-30 16:54:38]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-30 16:54:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062743006/40001

[commit-bot: I haz the power, 2015-04-30 17:00:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-30 17:00:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2015-04-30 17:54:10]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-30 17:54:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062743006/40001

[brettw, 2015-04-30 17:55:32]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2015-04-30 18:10:28]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-04-30 18:10:35]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-30 18:12:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062743006/60001

[commit-bot: I haz the power, 2015-04-30 19:20:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-30 19:20:33]

Dry run: Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Dirk Pranke, 2015-04-30 19:32:50]

lgtm w/ a couple of questions

https://codereview.chromium.org/1062743006/diff/60001/chrome/installer/util/B...
File chrome/installer/util/BUILD.gn (right):

https://codereview.chromium.org/1062743006/diff/60001/chrome/installer/util/B...
chrome/installer/util/BUILD.gn:235: "installer_util_unittests.rc",  # FIXME put
this back
what does this fixme mean?

https://codereview.chromium.org/1062743006/diff/60001/chrome/installer/util/B...
chrome/installer/util/BUILD.gn:259: ":strings",  # FIXME put this back
what does this fixme mean?

[brettw, 2015-04-30 19:49:17]

The comments were supposed to be deleted. Thanks.

[brettw, 2015-04-30 19:49:21]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-04-30 19:49:22]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1062743006/#ps80001
(title: "Fixes")

[commit-bot: I haz the power, 2015-04-30 19:52:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062743006/80001

[commit-bot: I haz the power, 2015-04-30 19:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-30 19:58:04]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_dbg on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_d...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[brettw, 2015-04-30 20:04:35]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-04-30 20:05:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062743006/80001

[brettw, 2015-04-30 20:06:24]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2015-04-30 20:06:33]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-04-30 20:08:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062743006/80001

[commit-bot: I haz the power, 2015-04-30 21:12:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-30 21:13:25]

Patchset 5 (id:??) landed as
https://crrev.com/cb55755a09b9e2d8c5b05b7a4ad2ff8631e15b13
Cr-Commit-Position: refs/heads/master@{#327790}

[rickyz (no longer on Chrome), 2015-04-30 21:46:00]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1116263002/ by rickyz@chromium.org.

The reason for reverting is: Compilation errors that look related to the
installer_util_strings.rc move:
http://build.chromium.org/p/chromium/builders/Win/builds/31460.