Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1062743005: GN Windows build fixes (Closed)

Created:
5 years, 8 months ago by brettw
Modified:
5 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wintests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN Windows build fixes Most importantly, this passes cflags_cc to the C++ compiler. This fixes some flag differences with the GYP build, especially when running on 64 bit. It disables a TLS test on static debug x64 builds which also fails in GYP. This configuration is not run on the bots but is the standard GN Windows build. BUG=251251 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/9a19ddbe04e2be759a15c6a70f6585152611af23 Cr-Commit-Position: refs/heads/master@{#326856}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M base/base.gyp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M base/threading/thread_local_storage_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M build/config/win/BUILD.gn View 1 chunk +12 lines, -2 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
brettw
5 years, 8 months ago (2015-04-20 22:24:49 UTC) #2
scottmg
lgtm
5 years, 8 months ago (2015-04-20 22:26:23 UTC) #3
scottmg
BUG=251251
5 years, 8 months ago (2015-04-20 22:26:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062743005/1
5 years, 8 months ago (2015-04-21 16:40:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062743005/1
5 years, 8 months ago (2015-04-21 16:43:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062743005/1
5 years, 8 months ago (2015-04-24 18:12:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062743005/20001
5 years, 8 months ago (2015-04-24 18:15:21 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 19:31:00 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 19:31:43 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a19ddbe04e2be759a15c6a70f6585152611af23
Cr-Commit-Position: refs/heads/master@{#326856}

Powered by Google App Engine
This is Rietveld 408576698