Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1062733009: dispatcher: updates go/infra/monitoring/messages to parse some more json formats (Closed)

Created:
5 years, 8 months ago by seanmccullough
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

dispatcher: updates go/infra/monitoring/messages to parse some more json formats This is part of a larger patch that I've broken up for review. BUG= Committed: https://chromium.googlesource.com/infra/infra/+/42ec1a1fbca6dc01e6973ee39a43b8bcb90b94f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -41 lines) Patch
M go/src/infra/monitoring/messages/alerts.go View 1 chunk +4 lines, -3 lines 0 comments Download
M go/src/infra/monitoring/messages/buildextract.go View 5 chunks +46 lines, -38 lines 0 comments Download
A go/src/infra/monitoring/messages/gatekeeper.go View 1 chunk +29 lines, -0 lines 0 comments Download
A go/src/infra/monitoring/messages/testresults.go View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
seanmccullough
Just struct changes, no logic.
5 years, 8 months ago (2015-04-17 18:51:01 UTC) #2
ghost stip (do not use)
doesn't look like a virus, lgtm
5 years, 8 months ago (2015-04-17 21:43:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062733009/1
5 years, 8 months ago (2015-04-17 21:49:12 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 22:34:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/42ec1a1fbca6dc01e6973ee39a43b...

Powered by Google App Engine
This is Rietveld 408576698