Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1062673003: Cleanup: Use uint8_t type throughout in the MD5 API. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Use uint8_t type throughout in the MD5 API. This seems to be more consistent with the use of uint32_t type that is also used throughout in this API. BUG=None TEST=base_unittests --gtest_filter=MD5* R=thestig@chromium.org Committed: https://crrev.com/6b950199c92a1fb530beb64110332b316528d9ae Cr-Commit-Position: refs/heads/master@{#323949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M base/md5.h View 2 chunks +3 lines, -1 line 0 comments Download
M base/md5.cc View 5 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
PTAL!
5 years, 8 months ago (2015-04-04 15:35:32 UTC) #1
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-06 18:53:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062673003/1
5 years, 8 months ago (2015-04-06 19:16:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 21:04:33 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 21:06:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b950199c92a1fb530beb64110332b316528d9ae
Cr-Commit-Position: refs/heads/master@{#323949}

Powered by Google App Engine
This is Rietveld 408576698