Issue 1062653002: Fix some issues when building Closure runner.jar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1062653002: Fix some issues when building Closure runner.jar (Closed)

Created:
5 years, 8 months ago by Dan Beam

Modified:
5 years, 8 months ago

Reviewers:
Tyler Breisacher (Chromium)

CC:
chromium-reviews, vitalyp+closure_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix some issues when building Closure runner.jar R=tbreisacher@chromium.org BUG=none Committed: https://crrev.com/dc25282f197e02790add7edee45412b9e67255d7 Cr-Commit-Position: refs/heads/master@{#323867}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	third_party/closure_compiler/compile_js.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/closure_compiler/externs/chrome_extensions.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePassConfig.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062653002/1

5 years, 8 months ago (2015-04-04 01:42:30 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-04 02:09:39 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/dc25282f197e02790add7edee45412b9e67255d7
Cr-Commit-Position: refs/heads/master@{#323867}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages