Re-implement %Generator% intrinsic as an object

test/mjsunit/builtins.js

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 21 matching lines @@
 // have only unconfigurable properties on the prototype, and the methods
 // are also non-writable.
 
 var names = Object.getOwnPropertyNames(builtins);
 
 function isFunction(obj) {
   return typeof obj == "function";
 }
 
 function isV8Native(name) {
-  return name == "GeneratorFunctionPrototype" ||
+  return name == "GeneratorFunction" ||
+      name == "GeneratorFunctionPrototype" ||
       name == "SetIterator" ||
       name == "MapIterator" ||
       name == "ArrayIterator" ||
       name == "StringIterator";
 }
+var V8NativePrototypes = {
+  GeneratorFunction: Function.prototype,
+  // TODO: Update the following values to the %IteratorPrototype% intrinsic

[caitp (gmail), 2015/04/06 18:05:05]

TODO(name): ...

+  //       once it is implemented.
+  // Issue 3568: Generator Prototype should have an object between itself

[caitp (gmail), 2015/04/06 18:07:03]

bug numbers might be iffy, especially if v8 has to migrate to a new issue
tracker once code.google.com is closed for good (which may not need to happen?
not sure)

[arv (Not doing code reviews), 2015/04/06 18:15:14]

Bug numbers are fine. We have them all over. It might be better to have the full
bug url here but it doesn't matter.

https://code.google.com/p/v8/issues/detail?id=3568

+  //             and Object.prototype
+  GeneratorFunctionPrototype: Object.prototype,
+  SetIterator: Object.prototype,
+  MapIterator: Object.prototype,
+  ArrayIterator: Object.prototype,
+  StringIterator: Object.prototype
+};
 
 function checkConstructor(func, name) {
   // A constructor is a function with a prototype and properties on the
   // prototype object besides "constructor";
   if (name.charAt(0) == "$") return;
   if (typeof func.prototype != "object") return;
   var propNames = Object.getOwnPropertyNames(func.prototype);
   if (propNames.length == 0 ||
       (propNames.length == 1 && propNames[0] == "constructor")) {
     // Not a constructor.
     return;
   }
   var proto_desc = Object.getOwnPropertyDescriptor(func, "prototype");
   assertTrue(proto_desc.hasOwnProperty("value"), name);
   assertFalse(proto_desc.writable, name);
   assertFalse(proto_desc.configurable, name);
   var prototype = proto_desc.value;
-  assertEquals(isV8Native(name) ? Object.prototype : null,
+  assertEquals(V8NativePrototypes[name] || null,
                Object.getPrototypeOf(prototype),
                name);
   for (var i = 0; i < propNames.length; i++) {
     var propName = propNames[i];
     if (propName == "constructor") continue;
     if (isV8Native(name)) continue;
     var testName = name + "-" + propName;
     var propDesc = Object.getOwnPropertyDescriptor(prototype, propName);
     assertTrue(propDesc.hasOwnProperty("value"), testName);
     assertFalse(propDesc.configurable, testName);
     if (isFunction(propDesc.value)) {
       assertFalse(propDesc.writable, testName);
     }
   }
 }
 
 for (var i = 0; i < names.length; i++) {
   var name = names[i];
   var desc = Object.getOwnPropertyDescriptor(builtins, name);
   assertTrue(desc.hasOwnProperty("value"));
   var value = desc.value;
   if (isFunction(value)) {
     checkConstructor(value, name);
   }
 }