Re-implement %Generator% intrinsic as an object

src/bootstrapper.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bootstrapper.h"
 
 #include "src/accessors.h"
 #include "src/api-natives.h"
 #include "src/code-stubs.h"
 #include "src/extensions/externalize-string-extension.h"
@@ skipping 2041 matching lines @@
         isolate()->initial_object_prototype(), Builtins::kIllegal);
     native_context()->set_map_iterator_map(
         map_iterator_function->initial_map());
   }
 
   {
     // Create generator meta-objects and install them on the builtins object.
     Handle<JSObject> builtins(native_context()->builtins());
     Handle<JSObject> generator_object_prototype =
         factory()->NewJSObject(isolate()->object_function(), TENURED);
-    Handle<JSFunction> generator_function_prototype =
-        InstallFunction(builtins, "GeneratorFunctionPrototype",
-                        JS_FUNCTION_TYPE, JSFunction::kHeaderSize,
-                        generator_object_prototype, Builtins::kIllegal);
+    Handle<JSObject> generator_function_prototype =
+        factory()->NewJSObject(isolate()->object_function(), TENURED);
+    JSObject::AddProperty(builtins,
+        factory()->InternalizeUtf8String("GeneratorFunctionPrototype"),

[caitp (gmail), 2015/04/06 16:31:24]

I think clang-format will complain about this indentation. The styles that it
prefers seems to be:

1) align everything with the ( paren, like this:

```
FunctionToCall(argument1,
                       
reallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyLongArgument2)
```

or 2) start the first argument 4 spaces in:

```
FunctionToCall(
    argument1,
reallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyLongArgument2)
```

If you run `git cl format src` it should fix it all up though (might want to
just target the specific files in your patch to avoid diff noise)

+        generator_function_prototype,
+        static_cast<PropertyAttributes>(DONT_ENUM | DONT_DELETE | READ_ONLY));
+
+    JSObject::AddProperty(generator_function_prototype,
+        factory()->InternalizeUtf8String("prototype"),
+        generator_object_prototype,
+        static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY));
+
     InstallFunction(builtins, "GeneratorFunction", JS_FUNCTION_TYPE,
                     JSFunction::kSize, generator_function_prototype,
                     Builtins::kIllegal);
 
     // Create maps for generator functions and their prototypes.  Store those
     // maps in the native context.
     Handle<Map> generator_function_map =
         Map::Copy(sloppy_function_map_writable_prototype_, "GeneratorFunction");
     generator_function_map->SetPrototype(generator_function_prototype);
     native_context()->set_sloppy_generator_function_map(
@@ skipping 876 matching lines @@
   return from + sizeof(NestingCounterType);
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   DCHECK(!IsActive());
 }
 
 } }  // namespace v8::internal