Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 106263004: [SVG] A minor clean up related to event listener attributes (Closed)

Created:
6 years, 11 months ago by pavane
Modified:
6 years, 11 months ago
CC:
blink-reviews, Steve Block, krit, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, shans, f(malita), darktears, pdr, Stephen Chennney, Eric Willigers, dino_apple.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[SVG] A minor clean up related to event listener attributes onbegin, onend and onrepeat attributes are valid only for animation elements. So, it is better for them to be in SVGSMILElement instead of SVGElement. R=pdr@chromium.org, schenney@chromium.org, dschulze@chromium.org, fmalita@chromium.org, rob.buis@samsung.com BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M Source/core/svg/SVGElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pavane
Please have a look at this patch.
6 years, 11 months ago (2014-01-02 22:20:43 UTC) #1
rwlbuis
On 2014/01/02 22:20:43, pavane wrote: > Please have a look at this patch. Good find! ...
6 years, 11 months ago (2014-01-02 22:31:52 UTC) #2
pavane
On 2014/01/02 22:31:52, rwlbuis wrote: > On 2014/01/02 22:20:43, pavane wrote: > > Please have ...
6 years, 11 months ago (2014-01-03 06:42:02 UTC) #3
rwlbuis
On 2014/01/03 06:42:02, pavane wrote: > On 2014/01/02 22:31:52, rwlbuis wrote: > > On 2014/01/02 ...
6 years, 11 months ago (2014-01-03 17:13:38 UTC) #4
pavane
can somebody rubber stamp this patch? Need a reviewer lgtm
6 years, 11 months ago (2014-01-06 20:22:17 UTC) #5
pdr.
On 2014/01/06 20:22:17, pavane wrote: > can somebody rubber stamp this patch? > > Need ...
6 years, 11 months ago (2014-01-06 20:40:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavan.e@samsung.com/106263004/1
6 years, 11 months ago (2014-01-06 20:53:58 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 00:04:31 UTC) #8
Message was sent while issue was closed.
Change committed as 164534

Powered by Google App Engine
This is Rietveld 408576698