Issue 1062603003: Add ACCESS_NETWORK_CONDITIONS permission to MojoShell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1062603003: Add ACCESS_NETWORK_CONDITIONS permission to MojoShell. (Closed)

Created:
5 years, 8 months ago by tonyg

Modified:
5 years, 8 months ago

Reviewers:
jamesr, qsr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add ACCESS_NETWORK_CONDITIONS permission to MojoShell. I had this in an earlier version of: https://codereview.chromium.org/1036403003/ But had removed it before uploading because I thought things worked without it. Turns out it is necessary after all for the network service to run on android wear. BUG= R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/14e86fd5fe7449bb48ec9376e2f220d9ebaec39c

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	shell/android/apk/AndroidManifest.xml	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

tonyg

5 years, 8 months ago (2015-04-03 23:34:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
14e86fd5fe7449bb48ec9376e2f220d9ebaec39c (presubmit successful).