Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: tools/json_schema_compiler/js_externs_generator_test.py

Issue 1062573004: [Extension API Extern Generation] Fix a few bugs in extern generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/js_externs_generator_test.py
diff --git a/tools/json_schema_compiler/js_externs_generator_test.py b/tools/json_schema_compiler/js_externs_generator_test.py
index 004b79c1f8d9c457dbe4aabc8672dd29577a3458..b74260daf86e5fcc0932bdd79b6501d651356fe6 100755
--- a/tools/json_schema_compiler/js_externs_generator_test.py
+++ b/tools/json_schema_compiler/js_externs_generator_test.py
@@ -43,6 +43,7 @@ namespace fakeApi {
Bar obj;
long? maybe;
(DOMString or Greek or long[]) choice;
+ object plainObj;
};
callback VoidCallback = void();
@@ -114,7 +115,8 @@ var Bar;
* anythingGoes: !Array<*>,
* obj: Bar,
* maybe: (number|undefined),
- * choice: (string|!chrome.fakeApi.Greek|!Array<number>)
+ * choice: (string|!chrome.fakeApi.Greek|!Array<number>),
+ * plainObj: Object
* }}
* @see https://developer.chrome.com/extensions/fakeApi#type-Baz
*/

Powered by Google App Engine
This is Rietveld 408576698