[NaCl SDK] nacl_io: Fix use-after-free bug in html5fs

native_client_sdk/src/libraries/nacl_io/devfs/dev_fs.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if defined(WIN32)
 #define _CRT_RAND_S
 #endif
 
 #include "nacl_io/devfs/dev_fs.h"
 
@@ skipping 230 matching lines @@
 }  // namespace
 
 Error DevFs::OpenWithMode(const Path& path, int open_flags,
                           mode_t mode, ScopedNode* out_node) {
   out_node->reset(NULL);
   int error;
   if (path.Part(1) == "fs") {
     if (path.Size() == 3) {
       error = fs_dir_->FindChild(path.Part(2), out_node);
     } else {
-      LOG_TRACE("Bad devfs path: %s", path.Join().c_str());
+      std::string path_str(path.Join());

[khim, 2015/04/17 21:20:05]

Fly-by comment: why "std:sttring" here? Why not "const std::string&" ?

I guess difference in speed shouldn't be large here, but still... it's probably
better explains what you are trying to achieve here.

[binji, 2015/04/20 22:35:28]

Done.

+      LOG_TRACE("Bad devfs path: %s", path_str.c_str());
       error = ENOENT;
     }
   } else {
     error = root_->FindChild(path.Join(), out_node);
   }
 
   // Only return EACCES when trying to create a node that does not exist.
   if ((error == ENOENT) && (open_flags & O_CREAT)) {
-    LOG_TRACE("Cannot create devfs node: %s", path.Join().c_str());
+    std::string path_str(path.Join());
+    LOG_TRACE("Cannot create devfs node: %s", path_str.c_str());
     return EACCES;
   }
 
   return error;
 }
 
 Error DevFs::Unlink(const Path& path) {
   LOG_ERROR("unlink not supported.");
   return EPERM;
 }
@@ skipping 77 matching lines @@
   // Add a directory for "fs" nodes; they represent all currently-mounted
   // filesystems. We can ioctl these nodes to make changes or provide input to
   // a mounted filesystem.
   INITIALIZE_DEV_NODE_1("/fs", DirNode, S_IRALL | S_IWALL | S_IXALL);
   fs_dir_ = new_node;
 
   return 0;
 }
 
 }  // namespace nacl_io