Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 1062403003: NaCl test script: get the run.py translation arch from the environment (Closed)

Created:
5 years, 8 months ago by Derek Schuff
Modified:
5 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-compiler-rt.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

NaCl test script: get the run.py translation arch from the environment When testing the bitcode compiler_rt, specify the translation arch from the environment rather than letting it default to the host architecture. This allows the different FYI bots to test with different architectures. R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-compiler-rt.git;a=commit;h=57f1c1d0e8d3f2f85b96c79d89f44b65c7d9fec0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/builtins/Unit/nacltest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Derek Schuff
5 years, 8 months ago (2015-04-08 17:13:07 UTC) #1
jvoung (off chromium)
lgtm
5 years, 8 months ago (2015-04-08 18:05:39 UTC) #2
Derek Schuff
5 years, 8 months ago (2015-04-08 18:56:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
57f1c1d0e8d3f2f85b96c79d89f44b65c7d9fec0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698