Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 1062403002: cc: Plumbing for storing property trees (Closed)

Created:
5 years, 8 months ago by enne (OOO)
Modified:
5 years, 8 months ago
Reviewers:
Ian Vollick, ajuma
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Plumbing for storing property trees In order to commit property trees to the compositor thread, they need to be stored on the LayerTreeHost/LayerTreeImpl. This change adds plumbing so that the PropertyTree computation is not entirely internal to CDP. BUG=386793 Committed: https://crrev.com/c3011475c142d226e28bd4256a12deeda139f783 Cr-Commit-Position: refs/heads/master@{#324331}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix perf test compile failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -38 lines) Patch
M cc/trees/draw_property_utils.h View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 1 1 chunk +7 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.h View 8 chunks +12 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_common_perftest.cc View 1 4 chunks +4 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M cc/trees/property_tree.h View 1 chunk +7 lines, -0 lines 0 comments Download
M cc/trees/property_tree_builder.h View 1 chunk +1 line, -3 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
enne (OOO)
5 years, 8 months ago (2015-04-07 23:57:14 UTC) #2
Ian Vollick
lgtm. https://codereview.chromium.org/1062403002/diff/1/cc/trees/property_tree.h File cc/trees/property_tree.h (right): https://codereview.chromium.org/1062403002/diff/1/cc/trees/property_tree.h#newcode200 cc/trees/property_tree.h:200: class CC_EXPORT PropertyTrees final { So much better!
5 years, 8 months ago (2015-04-08 02:45:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062403002/1
5 years, 8 months ago (2015-04-08 16:10:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/64149)
5 years, 8 months ago (2015-04-08 16:47:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062403002/20001
5 years, 8 months ago (2015-04-08 22:12:14 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 01:27:37 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 01:28:25 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c3011475c142d226e28bd4256a12deeda139f783
Cr-Commit-Position: refs/heads/master@{#324331}

Powered by Google App Engine
This is Rietveld 408576698