build/isolate.gypi - Issue 1062363002: Add comments about --config-vars that need to be in sync.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/isolate.gypi

Issue 1062363002: Add comments about --config-vars that need to be in sync. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: maruel Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/isolate.gypi

diff --git a/build/isolate.gypi b/build/isolate.gypi

index c85585dc1b9f9c591d7b516c450bef65590b1b6f..6b1796c917be9cfe08f9672ef2682e47eb3d1de4 100644

--- a/build/isolate.gypi

+++ b/build/isolate.gypi

@@ -61,9 +61,6 @@

# Variables should use the -V FOO=<(FOO) form so frequent values,

# like '0' or '1', aren't stripped out by GYP. Run 'isolate.py help' for

# more details.

- #

- # This list needs to be kept in sync with the cmd line options

- # in src/build/android/pylib/gtest/setup.py.

# Path variables are used to replace file paths when loading a .isolate

# file

@@ -74,6 +71,8 @@

# the .isolate file but are not considered relative paths.

'--extra-variable', 'version_full=<(version_full)',

+ # Note: This list must match DefaultConfigVariables()

+ # in build/android/pylib/utils/isolator.py

'--config-variable', 'CONFIGURATION_NAME=<(CONFIGURATION_NAME)',

'--config-variable', 'OS=<(OS)',

'--config-variable', 'asan=<(asan)',

« no previous file with comments | « build/android/pylib/utils/isolator.py ('k') | no next file » | no next file with comments »