Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: build/isolate.gypi

Issue 1062363002: Add comments about --config-vars that need to be in sync. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/isolate.gypi
diff --git a/build/isolate.gypi b/build/isolate.gypi
index c85585dc1b9f9c591d7b516c450bef65590b1b6f..cc7e97c8457d1a8ac2c09d7f49bf491a5a449786 100644
--- a/build/isolate.gypi
+++ b/build/isolate.gypi
@@ -74,6 +74,8 @@
# the .isolate file but are not considered relative paths.
'--extra-variable', 'version_full=<(version_full)',
+ # Note: This list must match DefaultConfigVariables()
+ # in build/android/pylib/utils/isolator.py
'--config-variable', 'CONFIGURATION_NAME=<(CONFIGURATION_NAME)',
'--config-variable', 'OS=<(OS)',
'--config-variable', 'asan=<(asan)',
« build/android/pylib/utils/isolator.py ('K') | « build/android/pylib/utils/isolator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698