Add comments about --config-vars that need to be in sync.

Add comments about --config-vars that need to be in sync.

BUG=none

Committed: https://crrev.com/1abe5b4643edb113d9ce3ac58c69d40967d74cc5
Cr-Commit-Position: refs/heads/master@{#324280}

[Nico, 2015-04-07 22:31:19]

thakis@chromium.org changed reviewers:
+ jbudorick@chromium.org, maruel@chromium.org

[jbudorick, 2015-04-07 22:35:35]

lgtm

[Nico, 2015-04-07 22:37:21]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-04-07 22:37:52]

(maruel: These two lists currently do _not_ match by the way. If this is
important, you might want to add the currently missing entries)

[commit-bot: I haz the power, 2015-04-07 22:38:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062363002/1

[M-A Ruel, 2015-04-07 22:38:45]

https://codereview.chromium.org/1062363002/diff/1/build/android/pylib/utils/i...
File build/android/pylib/utils/isolator.py (right):

https://codereview.chromium.org/1062363002/diff/1/build/android/pylib/utils/i...
build/android/pylib/utils/isolator.py:27: # Note: This list must match the
--config-vars in build/isolate.gypi
There was a comment but it looks like it was dropped off when someone refactored
this code.

https://codereview.chromium.org/1062363002/diff/1/build/isolate.gypi
File build/isolate.gypi (right):

https://codereview.chromium.org/1062363002/diff/1/build/isolate.gypi#newcode66
build/isolate.gypi:66: # in src/build/android/pylib/gtest/setup.py.
The script was renamed a while ago and this comment was not updated.

[jbudorick, 2015-04-07 22:38:48]

On 2015/04/07 22:37:52, Nico wrote:
> (maruel: These two lists currently do _not_ match by the way. If this is
> important, you might want to add the currently missing entries)

Were there differences other than internal_gles2_conform_tests?

[M-A Ruel, 2015-04-07 22:38:54]

The CQ bit was unchecked by maruel@chromium.org

[jbudorick, 2015-04-07 22:39:38]

On 2015/04/07 22:38:45, M-A Ruel wrote:
>
https://codereview.chromium.org/1062363002/diff/1/build/android/pylib/utils/i...
> File build/android/pylib/utils/isolator.py (right):
> 
>
https://codereview.chromium.org/1062363002/diff/1/build/android/pylib/utils/i...
> build/android/pylib/utils/isolator.py:27: # Note: This list must match the
> --config-vars in build/isolate.gypi
> There was a comment but it looks like it was dropped off when someone
refactored
> this code.

(I'm probably the "someone", sorry about that.)

> 
> https://codereview.chromium.org/1062363002/diff/1/build/isolate.gypi
> File build/isolate.gypi (right):
> 
> https://codereview.chromium.org/1062363002/diff/1/build/isolate.gypi#newcode66
> build/isolate.gypi:66: # in src/build/android/pylib/gtest/setup.py.
> The script was renamed a while ago and this comment was not updated.

[Nico, 2015-04-07 22:49:24]

https://codereview.chromium.org/1062363002/diff/1/build/isolate.gypi
File build/isolate.gypi (right):

https://codereview.chromium.org/1062363002/diff/1/build/isolate.gypi#newcode66
build/isolate.gypi:66: # in src/build/android/pylib/gtest/setup.py.
On 2015/04/07 22:38:44, M-A Ruel wrote:
> The script was renamed a while ago and this comment was not updated.

Done.

[Nico, 2015-04-08 17:59:14]

maruel: ping

[M-A Ruel, 2015-04-08 18:01:03]

lgtm

[Nico, 2015-04-08 18:01:35]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-04-08 18:01:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1062363002/#ps20001
(title: "maruel")

[commit-bot: I haz the power, 2015-04-08 18:03:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062363002/20001

[commit-bot: I haz the power, 2015-04-08 20:49:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-08 20:51:19]

Patchset 2 (id:??) landed as
https://crrev.com/1abe5b4643edb113d9ce3ac58c69d40967d74cc5
Cr-Commit-Position: refs/heads/master@{#324280}