Issue 1062353002: Revert of SkCanvas::resetForNextPicture()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1062353002: Revert of SkCanvas::resetForNextPicture() (Closed)

Created:
5 years, 8 months ago by mtklein

Modified:
5 years, 8 months ago

Reviewers:
mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of SkCanvas::resetForNextPicture() (patchset #4 id:60001 of https://codereview.chromium.org/1067893002/) Reason for revert: https://uberchromegw.corp.google.com/i/client.skia/builders/Linux%20Tests/builds/1816 Original issue's description: > SkCanvas::resetForNextPicture() > > No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu. > > picture_overhead_draw 1.62us -> 1.6us 0.99x > picture_overhead_nodraw 792ns -> 342ns 0.43x > > tiles and serialization modes will also test this a bit. > > BUG=chromium:470553 > > Committed: https://skia.googlesource.com/skia/+/f920e468ac66a36c9653d1b11181480295044c7d TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:470553 Committed: https://skia.googlesource.com/skia/+/c654e9016a15985ebeb24f94f819d113ad48a251

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -51 lines)			Patch
M	include/core/SkBitmapDevice.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	include/core/SkCanvas.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/core/SkBitmapDevice.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View	3 chunks	+0 lines, -28 lines	0 comments	Download
M	src/core/SkPictureRecorder.cpp	View	6 chunks	+4 lines, -6 lines	0 comments	Download
M	src/core/SkRecorder.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/core/SkRecorder.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062353002/1

5 years, 8 months ago (2015-04-07 22:27:07 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-07 22:27:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c654e9016a15985ebeb24f94f819d113ad48a251