Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 106233005: Add backported OrderedDict (Closed)

Created:
7 years ago by scottmg
Modified:
7 years ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Add backported OrderedDict Using collections.OrderedDict caused chromium roll to fail: Broke Win Builder (dbg) runhooks: File "C:\b\build\slave\cr-win-dbg\build\src\tools\gyp\pylib\gyp\generator\msvs.py", line 223, in _ConvertSourcesToFilterHierarchy folders = collections.OrderedDict() AttributeError: 'module' object has no attribute 'OrderedDict' R=thakis@chromium.org BUG=241769 Committed: https://code.google.com/p/gyp/source/detail?r=1816

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -1 line) Patch
M pylib/gyp/generator/msvs.py View 1 2 2 chunks +11 lines, -1 line 0 comments Download
A pylib/gyp/ordered_dict.py View 1 2 1 chunk +266 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
7 years ago (2013-12-13 17:47:20 UTC) #1
Nico
lgtm :-/ https://codereview.chromium.org/106233005/diff/20001/pylib/gyp/generator/msvs.py File pylib/gyp/generator/msvs.py (right): https://codereview.chromium.org/106233005/diff/20001/pylib/gyp/generator/msvs.py#newcode32 pylib/gyp/generator/msvs.py:32: OrderedDict = _import_OrderedDict() # TODO: Remove once ...
7 years ago (2013-12-13 17:54:18 UTC) #2
scottmg
https://codereview.chromium.org/106233005/diff/20001/pylib/gyp/generator/msvs.py File pylib/gyp/generator/msvs.py (right): https://codereview.chromium.org/106233005/diff/20001/pylib/gyp/generator/msvs.py#newcode32 pylib/gyp/generator/msvs.py:32: OrderedDict = _import_OrderedDict() On 2013/12/13 17:54:18, Nico wrote: > ...
7 years ago (2013-12-13 17:56:29 UTC) #3
scottmg
Committed patchset #3 manually as r1816.
7 years ago (2013-12-13 17:58:51 UTC) #4
Dirk Pranke
7 years ago (2013-12-13 19:55:48 UTC) #5
Message was sent while issue was closed.
Hm. Chromium is on 2.7 everywhere; do we know if there are other users (e.g.,
Node) that still need 2.6 ?

Powered by Google App Engine
This is Rietveld 408576698